Page MenuHomeHEPForge
Differential D117

Drop redundant EVTGEN_CPP11 preprocessor switch
ClosedPublic
Actions

Authored by tlatham on Apr 24 2024, 2:15 PM.

Details

Reviewers
jback
kreps
abudinen
Commits
rEVTGEN71451a4ee2bd: Drop redundant EVTGEN_CPP11 preprocessor switch
Summary

The EVTGEN_CPP11 preprocessor switch was introduced when compiler support for C++11 was variable.
Now we only support C++17 or later standards.
As such, this can be dropped.

This is related with !16.

Test Plan

Have run the full set of tests and the results are identical.

Diff Detail

Repository
rEVTGEN evtgen
Branch
tlatham_drop_CPP11_preproc
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 299
Build 299: arc lint + arc unit

Event Timeline

tlatham requested review of this revision.Apr 24 2024, 2:15 PM
tlatham created this revision.
Harbormaster completed remote builds in B299: Diff 482.Apr 24 2024, 2:15 PM
tlatham added reviewers: jback, kreps, abudinen.Apr 24 2024, 2:17 PM
tlatham changed the visibility from "All Users" to "Public (No Login Required)".
tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".
tlatham added a project: Restricted Project.
tlatham added a subscriber: Restricted Project.
abudinen edited the summary of this revision. (Show Details)Apr 24 2024, 2:50 PM
abudinen accepted this revision.EditedApr 24 2024, 2:52 PM

As discussed in !16, this old switch was currently still used only in examples and hence it is fine to remove it.

This revision is now accepted and ready to land.Apr 24 2024, 2:52 PM
Closed by commit rEVTGEN71451a4ee2bd: Drop redundant EVTGEN_CPP11 preprocessor switch (authored by tlatham). · Explain WhyApr 24 2024, 3:56 PM
This revision was automatically updated to reflect the committed changes.
tlatham added a commit: rEVTGEN71451a4ee2bd: Drop redundant EVTGEN_CPP11 preprocessor switch.

Revision Contents
Changeset List

PathSize
4 lines
src/
6 lines
test/
10 lines
10 lines
10 lines
10 lines
validation/
10 lines
9 lines
11 lines

Diff 482

View Options

History.md

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

test/evt_dalitz.cc

Loading...
View Options

test/evtgenlhc_test1.cc

Loading...
View Options

test/example1.cc

Loading...
View Options

test/exampleWriteHepMC.cc

Loading...
View Options

validation/genExampleRootFiles.cc

Loading...
View Options

validation/genRootDecayChain.cc

Loading...
View Options

validation/testCPVDecays.cc

Loading...