Page MenuHomeHEPForge
Differential D114

Simplified pre-processor behaviour for PHOTOS.
ClosedPublic
Actions

Authored by abudinen on Apr 17 2024, 4:38 PM.

Details

Reviewers
tlatham
jback
kreps
Commits
rEVTGEN593f5090a830: Simplified pre-processor behaviour for PHOTOS.
Summary

Moved pre-processor ifdef conditions from EvtPHOTOS class to EvtExternalGenList.

This is associated with T250 and !17.

Test Plan

Compilation and running with PHOTOS works.

Diff Detail

Repository
rEVTGEN evtgen
Branch
PHOTOSIfdefs
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 294
Build 294: arc lint + arc unit

Event Timeline

abudinen requested review of this revision.Apr 17 2024, 4:38 PM
abudinen created this revision.
Harbormaster completed remote builds in B294: Diff 475.Apr 17 2024, 4:38 PM
abudinen edited the summary of this revision. (Show Details)Apr 17 2024, 4:41 PM
abudinen changed the visibility from "All Users" to "Public (No Login Required)".
abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".
abudinen added a project: Restricted Project.
abudinen mentioned this in T250: Add new plug-ins for Final-State-Radiation.
abudinen updated this revision to Diff 477.Apr 22 2024, 4:55 PM
abudinen edited the summary of this revision. (Show Details)
  • Removed training space in History.md
Harbormaster completed remote builds in B296: Diff 477.Apr 22 2024, 4:55 PM
tlatham accepted this revision.Apr 22 2024, 4:57 PM

Many thanks @abudinen, looks great, please go ahead.

This revision is now accepted and ready to land.Apr 22 2024, 4:57 PM
Closed by commit rEVTGEN593f5090a830: Simplified pre-processor behaviour for PHOTOS. (authored by abudinen). · Explain WhyApr 22 2024, 5:05 PM
This revision was automatically updated to reflect the committed changes.
abudinen added a commit: rEVTGEN593f5090a830: Simplified pre-processor behaviour for PHOTOS..

Revision Contents
Changeset List

PathSize
EvtGenExternal/
6 lines
3 lines
src/
EvtGenExternal/
17 lines
65 lines

Diff 475

View Options

EvtGenExternal/EvtPHOTOS.hh

Loading...
View Options

History.md

Loading...
View Options

src/EvtGenExternal/EvtExternalGenList.cpp

Loading...
View Options

src/EvtGenExternal/EvtPHOTOS.cpp

Loading...