Protect eps and epsParent against wrong indices
ClosedPublic
Actions

Authored by abudinen on Feb 2 2024, 6:03 PM.

Details

Reviewers

tlatham
kreps
jback

Commits

rEVTGEN29c178f29f08: Protect eps and epsParent against wrong indices

Summary

Fixed loop over indices for vector states.

Added assert to check for right indices in polarisation vectors of vector and tensor particles.

Updated History.md.

Related with #12, !12 and T232.

Test Plan

Run all tests and check that output is the same.

Diff Detail

Repository

rEVTGEN evtgen

Branch

12-eps-VectorParticle

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 282
Build 282: arc lint + arc unit

Event Timeline

abudinen requested review of this revision.Feb 2 2024, 6:03 PM

abudinen created this revision.

Harbormaster completed remote builds in B280: Diff 442.Feb 2 2024, 6:03 PM

abudinen edited the summary of this revision. (Show Details)Feb 2 2024, 6:05 PM

abudinen changed the visibility from "All Users" to "Public (No Login Required)".

abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".

abudinen added a project: Restricted Project.

abudinen mentioned this in T232: Implement const correctness and protection against wrong indices for polarisation vectors.

These changes look OK, although I think you need to "undo" the fix for EvtBcVHad since this has been done in D100 that has been recently merged (which also makes significant changes to other parts of that class). So just update this class to the version in the current master, otherwise I think you will get a merge conflict (for those other parts that have changed).