Page MenuHomeHEPForge
Differential D107

Implemented const correctness for epsPhoton and epsParentPhoton
ClosedPublic
Actions

Authored by abudinen on Dec 19 2023, 4:05 PM.

Details

Reviewers
tlatham
jback
kreps
Maniphest Tasks
T232: Implement const correctness and protection against wrong indices for polarisation vectors
Commits
rEVTGEN3d020dadc019: Implemented const correctness for epsPhoton and epsParentPhoton
Summary

Implemented const correctness for photon polarisation vector.

Implemented const correctness for epsPhoton and epsParentPhoton.

Implemented const correctness in rotateToHelicityBasis functions that use epsPhoton.

Updated History.md

Related with #13, !13 and T232.

Test Plan

Run all relevant tests and check that the output remains constant.

Diff Detail

Repository
rEVTGEN evtgen
Branch
13-epsPhoton
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 278
Build 278: arc lint + arc unit

Event Timeline

abudinen requested review of this revision.Dec 19 2023, 4:05 PM
abudinen created this revision.
Harbormaster completed remote builds in B278: Diff 440.Dec 19 2023, 4:05 PM
abudinen mentioned this in T232: Implement const correctness and protection against wrong indices for polarisation vectors.Dec 19 2023, 4:11 PM
abudinen edited the summary of this revision. (Show Details)
tlatham changed the visibility from "All Users" to "Public (No Login Required)".Dec 19 2023, 4:16 PM
tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".
tlatham added a project: Restricted Project.
tlatham added a task: T232: Implement const correctness and protection against wrong indices for polarisation vectors.
jback accepted this revision.Feb 3 2024, 3:51 PM

Changes look OK, although you will need to update the History file to include the latest changes made by D100.

This revision is now accepted and ready to land.Feb 3 2024, 3:51 PM
tlatham updated this revision to Diff 446.Feb 19 2024, 10:15 AM

Rebase after landing of D100

Harbormaster completed remote builds in B283: Diff 446.Feb 19 2024, 10:15 AM
tlatham accepted this revision.Feb 19 2024, 10:17 AM
Closed by commit rEVTGEN3d020dadc019: Implemented const correctness for epsPhoton and epsParentPhoton (authored by abudinen, committed by tlatham). · Explain WhyFeb 19 2024, 10:18 AM
This revision was automatically updated to reflect the committed changes.
tlatham added a commit: rEVTGEN3d020dadc019: Implemented const correctness for epsPhoton and epsParentPhoton.
tlatham mentioned this in D108: Protect eps and epsParent against wrong indices.Feb 19 2024, 10:23 AM

Revision Contents
Changeset List

PathSize
EvtGenBase/
4 lines
7 lines
3 lines
src/
EvtGenBase/
4 lines
74 lines

Diff 440

View Options

EvtGenBase/EvtParticle.hh

Loading...
View Options

EvtGenBase/EvtPhotonParticle.hh

Loading...
View Options

History.md

Loading...
View Options

src/EvtGenBase/EvtParticle.cpp

Loading...
View Options

src/EvtGenBase/EvtPhotonParticle.cpp

Loading...