Only allow increase of C++ standard via environment variable
ClosedPublic
Actions

Authored by tlatham on Nov 15 2023, 1:00 PM.

Details

Reviewers

jback
kreps
abudinen

Commits

rEVTGENb2be5ef019be: Only allow increase of C++ standard via environment variable

Summary

Tweak to the part of the CMake configuration that allows the version of the C++ standard to be modified via the environment variable CMAKE_CXX_STANDARD.
The modified implementation only allows the value to be changed if the specified standard is newer than our default, currently C++17.

Test Plan

Configured the project with the environment variable set to 14 and 20 and obtained the expected behaviour: no change, standard bumped to C++20.

Diff Detail

Repository

rEVTGEN evtgen

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 274
Build 274: arc lint + arc unit

Event Timeline

tlatham requested review of this revision.Nov 15 2023, 1:00 PM

tlatham created this revision.

Harbormaster completed remote builds in B274: Diff 432.Nov 15 2023, 1:00 PM

tlatham edited the summary of this revision. (Show Details)Nov 15 2023, 1:02 PM

tlatham changed the visibility from "All Users" to "Public (No Login Required)".

tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".

tlatham added a project: Restricted Project.

tlatham retitled this revision from Allow increase of C++ standard via environment variable to Only allow increase of C++ standard via environment variable.

The changes look good to me. Ok, understood that this is just avoiding to use an user defined CMAKE_CXX_STANDARD if it is lower than our standard.

This revision is now accepted and ready to land.Nov 15 2023, 1:58 PM