Page MenuHomeHEPForge
Differential D105

Allow increase of C++ standard via environment variable
ClosedPublic
Actions

Authored by tlatham on Nov 15 2023, 12:55 PM.

Details

Reviewers
jback
Commits
rLAURA9172456ac117: Allow increase of C++ standard via environment variable
Summary

Tweak to CMake configuration to allow the version of the C++ standard to be
modified via the environment variable CMAKE_CXX_STANDARD.
The implementation only allows the change if the specified standard is newer
than our default, currently C++17.

Test Plan

Configured the project with the environment variable set to 14 and 20 and
obtained the expected behaviour: no change, standard bumped to C++20.

Diff Detail

Repository
rLAURA laura
Branch
tlatham_cmake_tweak
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 273
Build 273: arc lint + arc unit

Event Timeline

tlatham requested review of this revision.Nov 15 2023, 12:55 PM
tlatham created this revision.
Harbormaster completed remote builds in B273: Diff 431.Nov 15 2023, 12:55 PM
tlatham changed the visibility from "All Users" to "Public (No Login Required)".Nov 16 2023, 5:40 PM
tlatham changed the edit policy from "All Users" to "Laura (Project)".
tlatham added a project: Laura.
tlatham updated this revision to Diff 436.Nov 20 2023, 4:58 PM
  • Add warning if requested C++ standard is too old
Harbormaster completed remote builds in B275: Diff 436.Nov 20 2023, 4:58 PM
tlatham added a comment.Nov 21 2023, 10:46 PM

@jback, does this look ok? It's the same as the code we now have in #evtgen.

jback accepted this revision.Nov 22 2023, 12:46 PM

Yes, this is OK.

This revision is now accepted and ready to land.Nov 22 2023, 12:46 PM
Closed by commit rLAURA9172456ac117: Allow increase of C++ standard via environment variable (authored by tlatham). · Explain WhyNov 22 2023, 1:43 PM
This revision was automatically updated to reflect the committed changes.
tlatham added a commit: rLAURA9172456ac117: Allow increase of C++ standard via environment variable.

Revision Contents
Changeset List

PathSize
cmake/
Modules/
8 lines

Diff 431

View Options

cmake/Modules/LauraCompilerFlags.cmake

Loading...