Page MenuHomeHEPForge
Differential D97

Solved initialisation and pole issue in VTOSLL model.
ClosedPublic
Actions

Authored by abudinen on Aug 22 2023, 3:51 PM.

Details

Reviewers
tlatham
jback
kreps
Commits
rEVTGEN846fe14b4c2d: Solved initialisation and pole issue in VTOSLL model.
Summary

Solved initialisation and pole issue in VTOSLL model. Added two new test files for this model as well.

Implemented const where possible and needed as per John's comments.

Avoided unnecessary if loop and double initialization. Use static constexpr for pole size.

Test Plan

Distributions associated with propagator q2(ll) changed due to pole compensation.
Probmax issue should not happen when running the tests.

Diff Detail

Repository
rEVTGEN evtgen
Branch
5-fir-probmax-and-pole-issue-in-vtosll-model
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 258
Build 258: arc lint + arc unit

Event Timeline

abudinen requested review of this revision.Aug 22 2023, 3:51 PM
abudinen created this revision.
Harbormaster completed remote builds in B256: Diff 409.Aug 22 2023, 3:51 PM
abudinen added a project: Restricted Project.Aug 22 2023, 3:54 PM
abudinen updated this revision to Diff 410.Aug 22 2023, 4:00 PM
  • Updated History file.
Harbormaster completed remote builds in B257: Diff 410.Aug 22 2023, 4:00 PM
abudinen updated this revision to Diff 411.Aug 23 2023, 8:14 PM
  • Changed names of some variables to make it consistent with model name.
Harbormaster completed remote builds in B258: Diff 411.Aug 23 2023, 8:14 PM
tlatham added a comment.Aug 23 2023, 8:19 PM

Many thanks for this @abudinen. After the reviews by @jback and me on the CERN gitlab MR evtgen/evtgen!4, I think this is ready to go, unless @jback has any further comments, or @kreps would like to comment?

tlatham added reviewers: jback, kreps.Aug 23 2023, 8:20 PM
tlatham changed the visibility from "All Users" to "Public (No Login Required)".
tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".
tlatham mentioned this in T207: EvtGen models with test output problems.
tlatham edited subscribers, added: Restricted Project; removed: tlatham, kreps, jback.
jback accepted this revision.Aug 24 2023, 12:23 PM

Code looks good.

This revision is now accepted and ready to land.Aug 24 2023, 12:23 PM
kreps accepted this revision.Aug 30 2023, 3:58 PM

This all looks fine and as I would expect.

tlatham accepted this revision.Aug 30 2023, 4:19 PM

ok great, then this can go in, along with D94, I'll take care of landing them both tomorrow

tlatham added inline comments.Aug 31 2023, 3:19 PM
src/EvtGenModels/EvtVtoSll.cpp
159–163

I've just run this revision through the CI and I notice that this produces quite a lot of printout. Can we put this inside some sort of if ( m_debug ) condition so that it isn't normally printed?

abudinen updated this revision to Diff 415.Aug 31 2023, 10:47 PM
  • Avoid printout at every step in the scan to find probmax. Print info only at the end of the scan.
Harbormaster completed remote builds in B262: Diff 415.Aug 31 2023, 10:47 PM
Closed by commit rEVTGEN846fe14b4c2d: Solved initialisation and pole issue in VTOSLL model. (authored by abudinen, committed by tlatham). · Explain WhySep 20 2023, 6:37 PM
This revision was automatically updated to reflect the committed changes.
tlatham added a commit: rEVTGEN846fe14b4c2d: Solved initialisation and pole issue in VTOSLL model..

Revision Contents
Changeset List

PathSize
EvtGenModels/
9 lines
4 lines
src/
EvtGenModels/
203 lines
test/
jsonFiles/
26 lines
26 lines

Diff 411

View Options

EvtGenModels/EvtVtoSll.hh

Loading...
View Options

History.md

Loading...
View Options

src/EvtGenModels/EvtVtoSll.cpp

Loading...
View Options

test/jsonFiles/VTOSLL__Jpsi_pi0ee.json

Loading...
View Options

test/jsonFiles/VTOSLL__Jpsi_pi0mumu.json

Loading...