Paths

Table of Contentst

Differential D88

clang FIX-IT applied
ClosedPublic
Actions

Authored by sibid on Dec 12 2022, 8:42 PM.

Tags

Subscribers

Restricted Project

Details

Reviewers

Commits

rEVTGEN0b7719561720: Applied clang-tidy modernize-use-nullptr

Summary

clang FIX-IT applied

Test Plan

clang FIX-IT applied

Diff Detail

Repository

Branch

clang_check

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 235
Build 235: arc lint + arc unit

Event Timeline

sibid requested review of this revision.Dec 12 2022, 8:42 PM

sibid created this revision.

Harbormaster completed remote builds in B231: Diff 374.Dec 12 2022, 8:42 PM

This diff is after automatic clang fix of a nullptr usage.

tlatham changed the visibility from "All Users" to "Public (No Login Required)".Dec 13 2022, 11:45 AM

tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".

tlatham added a project: Restricted Project.

tlatham added a subscriber: Restricted Project.

Many thanks, this looks good. The only thing is that the source files in src/EvtGenExternal haven't been modified. Can you build with -DEVTGEN_PYTHIA=ON -DEVTGEN_PHOTOS=ON -DEVTGEN_TAUOLA=ON?

clang FIX-IT applied for externals

Harbormaster completed remote builds in B232: Diff 375.Dec 13 2022, 7:57 PM

Just 3 cases missed due to an #ifdef.
Otherwise I think it's looking good.
I'll try and run all the tests on it in the next few days to make completely certain, then this can be landed.

validation/testCPVDecays.cc
262
275
296

Tests look good. Once those three extra changes are done it can be merged.

add explicit nullptr in places which was shielded by a macro condition

Harbormaster completed remote builds in B235: Diff 379.Dec 16 2022, 5:34 PM

tlatham accepted this revision.Dec 16 2022, 5:47 PM

This revision is now accepted and ready to land.Dec 16 2022, 5:47 PM

tlatham added a commit: rEVTGEN0b7719561720: Applied clang-tidy modernize-use-nullptr.Dec 16 2022, 6:00 PM

Somehow I screwed up landing this and it hasn't automatically closed this revision. The changes are in master, however, so this can be closed manually.

Closed by commit rEVTGEN0b7719561720: Applied clang-tidy modernize-use-nullptr (authored by sibid, committed by tlatham). · Explain WhyDec 24 2022, 9:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

EvtGen/

23 lines

EvtGenBase/

2 lines

2 lines

EvtParticleDecay.hh

4 lines

EvtParticleDecayList.hh

2 lines

2 lines

3 lines

EvtStreamInputIterator.hh

2 lines

EvtGenModels/

EvtIntervalDecayAmp.hh

2 lines

2 lines

EvtMultibody.hh

4 lines

src/

8 lines

EvtGenBase/

23 lines

4 lines

EvtDecayAmp.cpp

8 lines

EvtDecayBase.cpp

2 lines

EvtDecayParm.cpp

10 lines

EvtDecayTable.cpp

8 lines

EvtExtGeneratorCommandsTable.cpp

4 lines

EvtHepMCEvent.cpp

19 lines

6 lines

6 lines

10 lines

EvtMultiChannelParser.cpp

6 lines

4 lines

EvtParticle.cpp

42 lines

EvtParticleDecay.cpp

2 lines

EvtParticleDecayList.cpp

18 lines

EvtParticleFactory.cpp

4 lines

EvtPto3PAmp.cpp

2 lines

EvtPto3PAmpFactory.cpp

38 lines

8 lines

4 lines

2 lines

EvtSpinDensity.cpp

6 lines

EvtdFunctionSingle.cpp

4 lines

EvtGenExternal/

EvtExternalGenFactory.cpp

8 lines

EvtExternalGenList.cpp

2 lines

EvtPhotosEngine.cpp

12 lines

2 lines

EvtPythiaEngine.cpp

18 lines

EvtTauolaEngine.cpp

8 lines

EvtGenModels/

EvtBtoXsgamma.cpp

2 lines

EvtD0gammaDalitz.cpp

2 lines

EvtDalitzTable.cpp

8 lines

EvtLb2Baryonlnu.cpp

6 lines

EvtLb2plnuLCSR.cpp

6 lines

EvtLb2plnuLQCD.cpp

6 lines

EvtMultibody.cpp

8 lines

EvtPropSLPole.cpp

10 lines

EvtRareLbToLll.cpp

4 lines

2 lines

2 lines

EvtVubHybrid.cpp

2 lines

EvtbTosllScalarAmpNew.cpp

4 lines

EvtbTosllScalarAmpNewExt.cpp

4 lines

EvtbTosllVectorAmp.cpp

4 lines

EvtbTosllVectorAmpNew.cpp

4 lines

EvtbTosllVectorAmpNewExt.cpp

4 lines

Evtbs2llGammaAmp.cpp

4 lines

Evtbs2llGammaISRFSRAmp.cpp

4 lines

EvtbsToLLLLAmp.cpp

8 lines

EvtbsToLLLLHyperCPAmp.cpp

8 lines

test/

4 lines

evtgenlhc_test1.cc

50 lines

6 lines

exampleWriteHepMC.cc

6 lines

validation/

compareRootFiles.cc

16 lines

genExampleRootFiles.cc

12 lines

genRootDecayChain.cc

14 lines

testCPVDecays.cc

18 lines

Diff 379

EvtGen/EvtGen.hh

Loading...

EvtGenBase/EvtModel.hh

Loading...

EvtGenBase/EvtParticle.hh

Loading...

EvtGenBase/EvtParticleDecay.hh

Loading...

EvtGenBase/EvtParticleDecayList.hh

Loading...

EvtGenBase/EvtPdf.hh

Loading...

EvtGenBase/EvtReport.hh

Loading...

EvtGenBase/EvtStreamInputIterator.hh

Loading...

EvtGenModels/EvtIntervalDecayAmp.hh

Loading...

EvtGenModels/EvtModelReg.hh

Loading...

EvtGenModels/EvtMultibody.hh

Loading...

src/EvtGen.cpp

Loading...

src/EvtGenBase/EvtCPUtil.cpp

Loading...

src/EvtGenBase/EvtCyclic3.cpp

Loading...

src/EvtGenBase/EvtDecayAmp.cpp

Loading...

src/EvtGenBase/EvtDecayBase.cpp

Loading...

src/EvtGenBase/EvtDecayParm.cpp

Loading...

src/EvtGenBase/EvtDecayTable.cpp

Loading...

src/EvtGenBase/EvtExtGeneratorCommandsTable.cpp

Loading...

src/EvtGenBase/EvtHepMCEvent.cpp

Loading...

src/EvtGenBase/EvtMHelAmp.cpp

Loading...

src/EvtGenBase/EvtMTree.cpp

Loading...

src/EvtGenBase/EvtModel.cpp

Loading...

src/EvtGenBase/EvtMultiChannelParser.cpp

Loading...

src/EvtGenBase/EvtParser.cpp

Loading...

src/EvtGenBase/EvtParticle.cpp

Loading...

src/EvtGenBase/EvtParticleDecay.cpp

Loading...

src/EvtGenBase/EvtParticleDecayList.cpp

Loading...

src/EvtGenBase/EvtParticleFactory.cpp

Loading...

src/EvtGenBase/EvtPto3PAmp.cpp

Loading...

src/EvtGenBase/EvtPto3PAmpFactory.cpp

Loading...

src/EvtGenBase/EvtRadCorr.cpp

Loading...

src/EvtGenBase/EvtRandom.cpp

Loading...

src/EvtGenBase/EvtReport.cpp

Loading...

src/EvtGenBase/EvtSpinDensity.cpp

Loading...

src/EvtGenBase/EvtdFunctionSingle.cpp

Loading...

src/EvtGenExternal/EvtExternalGenFactory.cpp

Loading...

src/EvtGenExternal/EvtExternalGenList.cpp

Loading...

src/EvtGenExternal/EvtPhotosEngine.cpp

Loading...

src/EvtGenExternal/EvtPythia.cpp

Loading...

src/EvtGenExternal/EvtPythiaEngine.cpp

Loading...

src/EvtGenExternal/EvtTauolaEngine.cpp

Loading...

src/EvtGenModels/EvtBtoXsgamma.cpp

Loading...

src/EvtGenModels/EvtD0gammaDalitz.cpp

Loading...

src/EvtGenModels/EvtDalitzTable.cpp

Loading...

src/EvtGenModels/EvtLb2Baryonlnu.cpp

Loading...

src/EvtGenModels/EvtLb2plnuLCSR.cpp

Loading...

src/EvtGenModels/EvtLb2plnuLQCD.cpp

Loading...

src/EvtGenModels/EvtMultibody.cpp

Loading...

src/EvtGenModels/EvtPropSLPole.cpp

Loading...

src/EvtGenModels/EvtRareLbToLll.cpp

Loading...

src/EvtGenModels/EvtVub.cpp

Loading...

src/EvtGenModels/EvtVubBLNP.cpp

Loading...

src/EvtGenModels/EvtVubHybrid.cpp

Loading...

src/EvtGenModels/EvtbTosllScalarAmpNew.cpp

Loading...

src/EvtGenModels/EvtbTosllScalarAmpNewExt.cpp

Loading...

src/EvtGenModels/EvtbTosllVectorAmp.cpp

Loading...

src/EvtGenModels/EvtbTosllVectorAmpNew.cpp

Loading...

src/EvtGenModels/EvtbTosllVectorAmpNewExt.cpp

Loading...

src/EvtGenModels/Evtbs2llGammaAmp.cpp

Loading...

src/EvtGenModels/Evtbs2llGammaISRFSRAmp.cpp

Loading...

src/EvtGenModels/EvtbsToLLLLAmp.cpp

Loading...

src/EvtGenModels/EvtbsToLLLLHyperCPAmp.cpp

Loading...

test/evt_dalitz.cc

Loading...

test/evtgenlhc_test1.cc

Loading...

test/example1.cc

Loading...

test/exampleWriteHepMC.cc

Loading...

validation/compareRootFiles.cc

Loading...

validation/genExampleRootFiles.cc

Loading...

validation/genRootDecayChain.cc

Loading...

validation/testCPVDecays.cc

Loading...