Fix LauFormulaPar to follow change in behaviour of TFormula
ClosedPublic
Actions

Authored by tlatham on Dec 2 2020, 5:36 PM.

Details

Reviewers

johndan
mwhitehe

Maniphest Tasks

T129: LauFormulaPar gives spurious error about dimension being 0 rather than 1

Commits

rLAURA89113f7a4cf8: Fix LauFormulaPar to follow change in behaviour of TFormula

Summary

Dimension returned by variable-less TFormula is now (sensibly) 0 rather than 1.
The dummy variable array passed to EvalPar is also no longer required.

Test Plan

Have created a LauFormulaPar and verified it gives the correct results as the
values of the underlying parameters change.

Diff Detail

Repository

rLAURA laura

Branch

T129

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 102
Build 102: arc lint + arc unit

Event Timeline

tlatham created this revision.Dec 2 2020, 5:36 PM

Harbormaster completed remote builds in B102: Diff 153.Dec 2 2020, 5:36 PM

tlatham changed the visibility from "All Users" to "Public (No Login Required)".Dec 2 2020, 5:38 PM

tlatham changed the edit policy from "All Users" to "Laura (Project)".

tlatham added a project: Laura.

Looks good to me

This revision is now accepted and ready to land.Dec 3 2020, 9:40 AM

Update release notes

Harbormaster completed remote builds in B103: Diff 154.Dec 3 2020, 10:39 AM

I tested the patch and it does the job.

Closed by commit rLAURA89113f7a4cf8: Fix LauFormulaPar to follow change in behaviour of TFormula (authored by tlatham). · Explain WhyDec 10 2020, 5:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

inc/

LauFormulaPar.hh

4 lines

src/

LauFormulaPar.cc

31 lines

Diff 153

View Options

inc/LauFormulaPar.hh