Page MenuHomeHEPForge
Differential D40

Allow slope of exponential non-resonant shape to vary positive (for low-stats fits)
ClosedPublic
Actions

Authored by johndan on Nov 18 2020, 1:46 PM.

Details

Reviewers
tlatham
Maniphest Tasks
T128: Issue with fit range of slope of exponential NR model
Commits
rLAURA19d7fe43bb14: Allow slope of exponential non-resonant shape to vary positive (for low-stats…
Test Plan

Already tested in B+ -> D+ D- K+ analysis

Diff Detail

Repository
rLAURA laura
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 93
Build 93: arc lint + arc unit

Event Timeline

johndan created this revision.Nov 18 2020, 1:46 PM
Harbormaster completed remote builds in B93: Diff 143.Nov 18 2020, 1:46 PM
johndan changed the edit policy from "All Users" to "Laura (Project)".Nov 18 2020, 1:47 PM
johndan added a project: Laura.
tlatham requested changes to this revision.Nov 23 2020, 9:16 AM

Hi Dan,

The code change is very straightforward, so no comments there!

However, just so I understand fully the motivation for the change, is this is just to allow for fluctuations (analogous to allowing negative yields)?

It would be great if you could also add a short description (referencing this Differential review) to doc/ReleaseNotes.md (hence the Request Changes status).

Cheers,
Tom

This revision now requires changes to proceed.Nov 23 2020, 9:16 AM
tlatham changed the visibility from "All Users" to "Public (No Login Required)".Nov 26 2020, 4:16 PM
johndan updated this revision to Diff 149.Nov 27 2020, 6:22 PM
  • Update release notes
Harbormaster completed remote builds in B99: Diff 149.Nov 27 2020, 6:22 PM
tlatham added a task: T128: Issue with fit range of slope of exponential NR model.Dec 2 2020, 12:07 PM
tlatham updated this revision to Diff 151.Dec 2 2020, 12:09 PM
  • Reference Maniphest task in release notes
Harbormaster completed remote builds in B101: Diff 151.Dec 2 2020, 12:09 PM
tlatham accepted this revision.Dec 2 2020, 12:10 PM

OK, good to go now, I'll take care of landing it later on.

This revision is now accepted and ready to land.Dec 2 2020, 12:10 PM
Closed by commit rLAURA19d7fe43bb14: Allow slope of exponential non-resonant shape to vary positive (for low-stats… (authored by johndan, committed by tlatham). · Explain WhyDec 2 2020, 1:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 143

View Options

src/LauBelleNR.cc

Loading...