Only spotted a few minor things, otherwise this is ready to be merged.

I have a few minor suggestions about adding more comments and have suggested a way that we can define the Sherpa parameters via the decay file.

Looks good to me, many thanks @abudinen! But let's give the others some time to check through again just to be sure.

• Moved internal Sherpa configurations for RNG interface into a dedicated cpp file.

@kreps, @jback, @averbyts please let me know if you have any comments

Thanks for the replies tlatham. I am happy with the implementations of them. Since the results of the tests look, as expected, numerically identical, except for the few cases where the changes are understood (and where the models need anyway fixing), I think that this differential is ready to be landed.

I have run all the tests on master and on the branch with these changes on top.

• Comments from Fernando

Thanks for the check through @abudinen - I've replied to your comments inline, and will shortly push up the corresponding changes.

I spotted a few places where we could get rid of commented code and I also have a few questions out of curiosity. Presumably, the output of the tests will be identical with the master branch. In which case, I think that this differential is ready to be landed.

Rebase on master branch:

• Rename member variables to avoid leading underscores
• Enable shadowing and overloaded-virtual compiler warnings
• Doxygen fixes
• Add check of member variable names in CI

As discussed in !16, this switch was now used only in examples and hence it is fine to remove it.

Closing this revision after the changes have been landed in the commit 71807eba8af5.

Thanks @abudinen, looks good to me

• Updated History.md

Many thanks @abudinen, looks great, please go ahead.

• Removed training space in History.md

I added a few points to consult with Sherpa experts as we discussed.

Thanks for checking! Ok, will land this differential.

Great, thanks for checking it over @jback!

I agree that these changes look OK.

Looks good to me. However, I think it would be good to have @jback check the changes introduced since his review on EvtGen!9 last Monday, in particular the neverRadCorr fix. The changes introduced in the last week can be seen here:
https://gitlab.cern.ch/evtgen/evtgen/-/compare/7e56b47604d68f89d00842409aeab2f9f1414b04...9-replace-photos-flag

Great, many thanks @abudinen! I have no further comments following the thorough review already conducted in EvtGen!10. Please go ahead and land this.

• Reverted doRadCorr function to not be const for semantic correctness in Vincia and Sherpa interfaces.

This was solved in D107 and D108.

Thanks both, I'll go ahead and land this. Unusually I'm going to use the "merge" strategy in this case rather than the usual "squash" strategy, since I think having the intermediate commits in the history will make it simpler to restore any individual models in the future if we need to do so.

Rebase on master

This is ready to be merged.

The changes look good to me.

Thanks @abudinen, I've added the lists you requested to the History file.

• Add lists of removed models and EvtGenBase classes