- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Thu, May 16
Wed, May 15
Closed by D86
Closed by D109
Tue, May 14
- Fix problem with GCC13 compilation of EvtSherpaRandom
- Add option for saving GCC temporary files (commented out for now)
- Fix problem with GCC13 compilation of EvtSherpaRandom
This code is ready to be merged. We will leave the ability to change the Sherpa configuration via decay file parameters as a future enhancement.
Mon, May 13
- Moved internal Sherpa configurations for RNG interface into a dedicated cpp file.
- Adapt setupEvtGen.sh to new Photos and Tauola URLs
- Update CI and Doxygen configs to include Sherpa
- Disable Sherpa in HepMC2 build
- Implemented comments by John.
Thu, May 9
Wed, May 8
Not sure why this wasn't automatically closed when bd48b7fe5585 was committed, so closing it manually
- Fixup changes from comments
- Update History.md
Tests are all good, so I'll go ahead and land this.
Tue, May 7
- Comments from John
Many thanks @jback - see replies inline.
Will push the small changes here in a second.
I'm re-running the tests just to make sure nothing changes - if all is ok I'll land this tomorrow.
Thu, May 2
Only spotted a few minor things, otherwise this is ready to be merged.
I have a few minor suggestions about adding more comments and have suggested a way that we can define the Sherpa parameters via the decay file.
Wed, May 1
Looks good to me, many thanks @abudinen! But let's give the others some time to check through again just to be sure.
- Moved internal Sherpa configurations for RNG interface into a dedicated cpp file.
Tue, Apr 30
Mon, Apr 29
Thanks for the replies tlatham. I am happy with the implementations of them. Since the results of the tests look, as expected, numerically identical, except for the few cases where the changes are understood (and where the models need anyway fixing), I think that this differential is ready to be landed.
I have run all the tests on master and on the branch with these changes on top.
- Comments from Fernando
Thanks for the check through @abudinen - I've replied to your comments inline, and will shortly push up the corresponding changes.
Fri, Apr 26
I spotted a few places where we could get rid of commented code and I also have a few questions out of curiosity. Presumably, the output of the tests will be identical with the master branch. In which case, I think that this differential is ready to be landed.
Rebase on master branch:
- Rename member variables to avoid leading underscores
- Enable shadowing and overloaded-virtual compiler warnings
- Doxygen fixes
- Add check of member variable names in CI
Thu, Apr 25
Wed, Apr 24
As discussed in !16, this switch was now used only in examples and hence it is fine to remove it.
Tue, Apr 23
Closing this revision after the changes have been landed in the commit 71807eba8af5.
Thanks @abudinen, looks good to me
Mon, Apr 22
- Updated History.md
Many thanks @abudinen, looks great, please go ahead.
- Removed training space in History.md
Fri, Apr 19
I added a few points to consult with Sherpa experts as we discussed.
Apr 17 2024
Apr 16 2024
Thanks for checking! Ok, will land this differential.
Great, thanks for checking it over @jback!
I agree that these changes look OK.
Apr 15 2024
Looks good to me. However, I think it would be good to have @jback check the changes introduced since his review on EvtGen!9 last Monday, in particular the neverRadCorr fix. The changes introduced in the last week can be seen here:
https://gitlab.cern.ch/evtgen/evtgen/-/compare/7e56b47604d68f89d00842409aeab2f9f1414b04...9-replace-photos-flag
Apr 12 2024
Great, many thanks @abudinen! I have no further comments following the thorough review already conducted in EvtGen!10. Please go ahead and land this.
- Reverted doRadCorr function to not be const for semantic correctness in Vincia and Sherpa interfaces.