Page MenuHomeHEPForge

No OneTemporary

diff --git a/ChangeLog b/ChangeLog
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,1815 +1,1821 @@
+2018-04-27 Andy Buckley <andy.buckley@cern.ch>
+
+ * Fix missing lock=false flag initialisation in Histo2D constructor from a Bins vector.
+
+ * Improve axis locking error messages.
+
2017-12-21 Andy Buckley <andy.buckley@cern.ch>
* Version 1.7.0 release
2017-12-11 Andy Buckley <andy.buckley@cern.ch>
* Add Nentries printout to yodals -v
2017-09-18 Andy Buckley <andy.buckley@cern.ch>
* Patches for ROOT conversion from Robert Hatcher -- thanks!
2017-09-16 Andy Buckley <andy.buckley@cern.ch>
* Add YODA format version annotation, at version 2, and update
YODA reader to use version info and multiline YAML EOF marker.
* Write YODA annotations in YAML with a --- YAML break-line.
2017-09-14 Andy Buckley <andy.buckley@cern.ch>
* Enable compressed writing from Python.
2017-09-13 Andy Buckley <andy.buckley@cern.ch>
* Remove UNUSED macro in favour of anonymous args.
* Enable zipped writing... but only works from C++ so far.
2017-09-11 Andy Buckley <andy.buckley@cern.ch>
* Add HistoBin2D::area(), and provide a default normto=1.0
argument on the Python Histo2D.normalize() method.
2017-09-04 Andy Buckley <andy.buckley@cern.ch>
* Change license explicitly to GPLv3, cf. MCnet3 agreement.
* Parse YODA format AO headers as YAML (restriction to single-line dict entries for now).
2017-08-24 Andy Buckley <andy.buckley@cern.ch>
* Use a slightly enhanced fast numeric parser in ReaderYODA (taken
from LHAPDF, originally inspired by Gavin Salam).
* Add an UNSCALE spec option to yodascale, to undo ScaledBy effects.
2017-08-19 Andy Buckley <andy.buckley@cern.ch>
* Add optional zlib support via zstr -- massive thanks to Dmitry
Kalinkin for the lovely patch!
2017-08-16 Andy Buckley <andy.buckley@cern.ch>
* Fix setVal(i, x) numbered-axis methods on Point2D and Point3D:
switch break statements were missing.
* Explicitly load all ROOT objects as a list rather than
generator. Patch from Dmitry Kalinkin.
2017-07-24 Andy Buckley <andy.buckley@cern.ch>
* Improvements to yodaplot, including two operating modes: the
default CMP mode is suitable for plotting histos by path, from raw
.yoda files.
* Update yoda.plotting functions to treat plot-keys as args and AO
annotations via case-insensitive keys.
* Add annotationsDict to the Python AO interface.
* Add AO as an alias for AnalysisObject.
2017-07-23 Andy Buckley <andy.buckley@cern.ch>
* Add parallel/compatibility yoda1 package to aid eventual transition to YODA v2.
2017-07-22 Andy Buckley <andy.buckley@cern.ch>
* Add x,y,zMins and Maxs to all 1D data types and scatters (and
x,yMin/Max to the scatters) -- Python interface only.
* Rework some of the yoda.plotting tools, making it a bit more
compatible with user-scripted matplotlib.
2017-07-18 Andy Buckley <andy.buckley@cern.ch>
* Add convenience aliases H1D, H2D, P1D, P2D, and S1D, S2D, S3D
for the HistoXD, ProfileXD, and ScatterXD classes respectively.
2017-07-08 Andy Buckley <andy.buckley@cern.ch>
* Add xyVals/Errs and other 'bin array property' accessors to the
Python Histo1D and Profile1D types: important for connection to
matplotlib.
2017-06-28 Andy Buckley <andy.buckley@cern.ch>
* Use Python natsort library to sort yodals output if available.
2017-06-18 Andy Buckley <andy.buckley@cern.ch>
* Version 1.6.7 release.
2017-05-12 Andy Buckley <andy.buckley@cern.ch>
* pyext/yoda/rootcompat.pyx: Fix ordering of TH1 vs. TProfile
conversion -- TProfile *is* a TH1, so we have to test for the more
specific type-match first. Thanks to Dmitry Kalinkin for the
patch.
2017-05-02 Andy Buckley <andy.buckley@cern.ch>
* Add static Reader methods to match the Writer ones.
2017-02-23 Andy Buckley <andy.buckley@cern.ch>
* Fix Histo2D and Profile2D total distribution reading from YODA format.
2017-02-19 Holger Schulz <holger.schulz@durham.ac.uk>
* Convert TH1F to TH1D in root2flat. Much simpler than duplicating
the TH1D stuff in pyext.
2016-12-13 Andy Buckley <andy.buckley@cern.ch>
* Version 1.6.6 release.
2016-12-12 Holger Schulz <holger.schulz@durham.ac.uk>
* Bugfixes in Cython bins accessors for Histo2D.
2016-11-17 Leif Lonnblad <leif.lonnblad@thep.lu.se>
* Fixed warning messages about the obsoleteness of AIDA so that the scripts actually still work.
2016-09-28 Andy Buckley <andy.buckley@cern.ch>
* Version 1.6.5 release, for the benefit of ROOT fans.
* Fix handling of --enable/disable-root configure options.
2016-09-26 David Grellscheid <david.grellscheid@durham.ac.uk>
* Improvements to Cython version testing.
2016-09-25 Andy Buckley <andy.buckley@cern.ch>
* Version 1.6.4 release.
2016-09-20 David Grellscheid <david.grellscheid@durham.ac.uk>
* Remove aliases for @property functions. They were scheduled for
removal anyway, and don't work with Cython >= 24.
2016-09-06 Andy Buckley <andy.buckley@cern.ch>
* Update configure scripts to use newer (Py3-safe) Python testing
macros.
2016-08-09 Andy Buckley <andy.buckley@cern.ch>
* Version 1.6.3 release!
2016-07-22 Andy Buckley <andy.buckley@cern.ch>
* Add 'add' modes for scatter combination to yodamerge.
* Fix yodamerge scatter averaging to use the first AO.
2016-07-21 Andy Buckley <andy.buckley@cern.ch>
* Add --type-mismatch-mode flag and fallback logic to yodamerge.
* Fix yodamerge logic to handle cases where an AO only appears once.
2016-07-19 Andy Buckley <andy.buckley@cern.ch>
* Deprecate flat2yoda script and add warning output to it and the AIDA conversion scripts.
* Add a convenience yoda2yoda script.
2016-07-14 Andy Buckley <andy.buckley@cern.ch>
* Try to build PyROOT interface by default, if root-config is found.
2016-07-11 Andy Buckley <andy.buckley@cern.ch>
* Remove accidentally remaining reference to Boost flags in yoda-config.
2016-07-06 Andy Buckley <andy.buckley@cern.ch>
* Version 1.6.2 release!
2016-07-05 Andy Buckley <andy.buckley@cern.ch>
* Pass the toNewScatter3D() scalebyarea flag to the called toScatter3D() functions.
2016-06-06 Andy Buckley <andy.buckley@cern.ch>
* Re-enable the disabled-for-some-reason Scatter1D combineWith Python mappings.
2016-04-28 Andy Buckley <andy.buckley@cern.ch>
* Version 1.6.1 release!
* Add a unit test for annotation handling correctness.
* Fix numerical precision of string storage of floating-point attributes.
* Fix a bug in use of the replacement for lexical_cast.
2016-04-20 Andy Buckley <andy.buckley@cern.ch>
* Version 1.6.0 release!
2016-04-16 Andy Buckley <andy.buckley@cern.ch>
* Extend SFINAE craziness to allow writing of any object
(e.g. smart pointer) that can be dereferenced to something that
has AnalysisObject as its base class... and also to any container
of them! Amazing what you can do with C++11!
2016-04-14 Andy Buckley <andy.buckley@cern.ch>
* Add a few consts to the arguments in Scatter error setting via pairs.
* Fix double-writing of minus errors in WriterYODA for Scatter1D
and Scatter3D. Thanks to Graeme Watt for the report and fix.
2016-04-12 Andy Buckley <andy.buckley@cern.ch>
* Remove Boost dependency and require C++11 compilation.
2016-04-08 Andy Buckley <andy.buckley@cern.ch>
* Add a --guess-prefix flag to yoda-config, cf. fastjet-config.
2015-12-20 Andy Buckley <andy.buckley@cern.ch>
* Change AO uncomputable division and mkScatter operations to
return/set NaN rather than 0 -- behaviour change requires new
major version series 1.6.
2016-03-09 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.9! (oh no, we're out of convenient version number space!!)
2016-03-08 Andy Buckley <andy.buckley@cern.ch>
* Add abs function to eq calculation in yodadiff.
2016-02-29 Andy Buckley <andy.buckley@cern.ch>
* Remove blocking of builds against ROOT6 -- it works fine.
2016-02-16 Andy Buckley <andy.buckley@cern.ch>
* Add a --add option to yodamerge, for simple histo
stacking. Thanks to Chris Gutschow for the patch, although my
spidey sense is tingling...
2015-12-21 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.8!
* Add a rebinning unit test, pytest-rebin.
* Add optional range arguments to rebinBy methods, allowing block
rebinnings to be applied only within a range of (original) bin
indices.
* Add missing root.py submodule file. Oops!
2015-12-20 Andy Buckley <andy.buckley@cern.ch>
* Convert linspace to use multiplication rather than repeated
addition to construct edge values, reducing precision errors.
Thanks to Holger Schulz for the suggestion.
2015-12-15 Andy Buckley <andy.buckley@cern.ch>
* Add xEdges() methods to Axis1D and the Histo1D and Profile1D
that use it. The returned edge lists are finite only, i.e. they do
not contain the +-inf values on the ends of the internal
BinSearcher edges.
2015-12-13 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.7!
* Extend batch-adding in ReaderYODA to include Scatter types.
* Add a match_aos function to Python, for filtering AO lists/dicts
on path patterns and anti-patterns.
2015-12-12 Andy Buckley <andy.buckley@cern.ch>
* Add a flag to yoda2root to change whether the conversion is to
'proper' types or to (more robustly) TGraphAsymmErrors objects.
* Fix accidental use of S2D_MODE flag where S1D_MODE should have
been used, in yodamerge. Thanks again to Radek Podskubka.
* Allow new rebinTo() merging to restrict to a subset of the bin
range, merging the outside bins into the overflow distributions.
2015-12-11 Andy Buckley <andy.buckley@cern.ch>
* Add a rebinTo() method on Axis1D, allowing rebinning to a new
given set of bin edges. Add an explicitly named rebinBy(), and
overloaded rebin() aliases for both, and pass through to Histo1D
and Profile1D APIs. Plus other internal tweaks to binning
functionality... anticipating/fuelling the fundamental rewrite.
2015-12-10 Andy Buckley <andy.buckley@cern.ch>
* Improve ReaderYODA to use temporary bin containers, to minimise
calling sort when adding bins to histos. A quick test suggests
this has sped up big file reading by a factor of 30 or so!!!
* Add missing addBins() operators (only in C++ so far) to Histo
and Profile classes.
* Fix Counter::numEntries to return an unsigned long rather than double.
Thanks to Radek Podskubka for the bug discovery and detective work.
* Improve sortedvector to insert new elements into the sorted
position, rather than resorting the whole vector. This should be a
bit more efficient, but I think the asymptotic complexity is the
same. Might help a bit with reading big data files.
2015-12-04 Andy Buckley <andy.buckley@cern.ch>
* Add yoda.HAS_ROOT_SUPPORT flag, for API user convenience.
2015-11-22 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.6!
* Make AO path setting and retrieval prepend a leading slash if it
is missing (unless the path is completely empty).
2015-11-21 Andy Buckley <andy.buckley@cern.ch>
* Add root2yoda conversion script.
* Deprecating yoda.to_root() in favour of yoda.root module, which
contains to_root and to_yoda functions, as well as a ROOT file
walking function.
2015-11-17 Andy Buckley <andy.buckley@cern.ch>
* Map ROOT-to-YODA (as scatter) functions to Python. Phew.
* Map new to-ROOT functions, including TGraph ones, to Python.
2015-11-16 Andy Buckley <andy.buckley@cern.ch>
* ROOTCnv.h: Add toScatter3D ROOT->YODA, and toNew* YODA->ROOT
conversion routines.
* ROOTCnv.h: Fix bug in toTH2D(const Histo2D& h) as used with
ROOT6. Thanks to Tim Martin.
2015-11-05 Andy Buckley <andy.buckley@cern.ch>
* Fix double-dealloc in new Point class hierarchy Python mapping.
2015-10-23 Andy Buckley <andy.buckley@cern.ch>
* Make the version() function inline, and the numerical constants static.
* Change the default plotting backend to MPL rather than the much slower PGF.
2015-10-09 Andy Buckley <andy.buckley@cern.ch>
* Reinstate __getitem__ special methods for Scatters in Python.
* Provide dim() methods/attributes for the Point and Bin base classes.
* Rename set*Err to set*Errs for the asymmetric variants. Plural
aliases are also provided for the symm case.
2015-10-08 Andy Buckley <andy.buckley@cern.ch>
* Pass std::pairs by reference in Point*D error setting functions.
* Add Point base class with generic accessors to Point*D
properties via an integer axis ID argument.
2015-10-07 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.5 release.
* Counter.pyx: Typo fix in sumW mapping.
* yodamerge: Re-add checking for non-emptiness before merging, in
case the empty ones are missing a ScaledBy attribute. Won't
normally apply to Profiles, since they don't usually get
normalised, but we might as well include them in the vetoing since
empty histos don't contribute to the merging. Added a command-line
option to disable this heuristic since in very strange situations
a null sumW does not mean no fills.
2015-10-06 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.4 release.
* ReaderYODA: Typo fixes in Counter filling of sumW and Scatter3D reader state flag.
* yodamerge: add merging heuristics for Scatter1D and Scatter3D (needs unification)
2015-10-05 Andy Buckley <andy.buckley@cern.ch>
* yodamerge: add a fix for empty-in-all-runs histo merging; thanks
to Daniel Rauch.
2015-10-04 Andy Buckley <andy.buckley@cern.ch>
* Adding dim() function and corresponding Python attribute to AnalysisObject.
* Map Counter arithmetic operations into Python.
* Map Counter mkScatter() into Python (as bound method).
* Add a YODA::version() function, mapped into Python and used to
set the yoda.__version__ variable.
2015-10-01 Andy Buckley <andy.buckley@cern.ch>
* Expose the yoda.plot() Python function in a way that doesn't
automatically induce a dependence on matplotlib.
2015-09-30 Andy Buckley <andy.buckley@cern.ch>
* Fix yodals to work with Counters.
2015-09-23 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.3 release.
* Update Boost version requirement to 1.48, due to use of
type_traits/has_dereference, and add a check for that feature's
header.
2015-09-19 Andy Buckley <andy.buckley@cern.ch>
* Further improvements to handling leading _multiple_ # marks on
YODA format BEGIN lines.
2015-09-11 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.2 release.
* Tolerate leading # symbols without separating whitespace on
BEGIN lines in YODA format parsing.
* Further improvements to handling LowStatsErrors in YODA format writing.
* Fix shadowed variables that made ReaderYODA unhappy.
2015-09-03 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.1 release.
* Fix bugs in Python wrapper for Point3D.
2015-08-28 Peter Richardson <Peter.Richardson@durham.ac.uk>
* Catch LowStatsError when writing multiple histograms so only the
histogram with the problem is not written
2015-08-28 Andy Buckley <andy.buckley@cern.ch>
* Version 1.5.0 release.
2015-08-24 Andy Buckley <andy.buckley@cern.ch>
* Improve protection of efficiency calculation against the weird
world of general weighted events.
2015-08-17 Andy Buckley <andy.buckley@cern.ch>
* Add some protection against calling matplotlib's legend() method
if there are no valid labels to display, to suppress an MPL
warning message when using yoda.plot().
2015-08-12 Andy Buckley <andy.buckley@cern.ch>
* Fix cut & paste typo, and add LowStatsError catching in Profile division.
2015-08-11 Andy Buckley <andy.buckley@cern.ch>
* Replace old Spirit-based ReaderYODA with the new hand-rolled one.
* Adding filling of Histo1D, Profile1D, Histo2D and Profile2D in
new ReaderYODA. More hacking of Axis and Histo/Profile
interfaces... needs clean-up, and infinite binning implementation.
2015-08-07 Andy Buckley <andy.buckley@cern.ch>
* Convert the ReaderFLAT parser to also use a simple hand-written parser rather than Spirit.
2015-08-04 Andy Buckley <andy.buckley@cern.ch>
* Add methods for Counter, Axis and Histo1D internal state
access/setting, mainly for new persistency. NEEDS PRE-RELEASE TESTING!!!
2015-07-30 Andy Buckley <andy.buckley@cern.ch>
* Remove # markers from YODA format BEGIN/END output. The parser
will continue to accept them.
2015-07-29 Andy Buckley <andy.buckley@cern.ch>
* Add SFINAE trait magic to restrict write(RANGE) functions to
accepting iterables. Also generalising to allow either
container-of-objects or container-of-pointers args by providing a
writeBody(AO*) function to complement writeBody(AO&). Based on a
patch from Lukas Heinrich.
* Add configuration of output streams to throw exceptions on
bad/fail state (based on patch from Lukas Heinrich).
2015-07-01 Andy Buckley <andy.buckley@cern.ch>
* 1.4.0 release.
2015-06-30 Andy Buckley <andy.buckley@cern.ch>
* More tweaks to yodamerge: adding control of S2D merging
strategy, and now performing weighted normalized histo merges
without reference to an absolute normalization.
* Change yodamerge norm-detection heuristic to just look for a
ScaledBy attribute rather than fuzzily compare norms.
2015-06-26 Andy Buckley <andy.buckley@cern.ch>
* Removing add, subtract, and divide functions and operators on
Scatter types, and re-implementing Histo and Profile divide
functions explicitly rather than via mkScatter. Also removed from
the Python interface. The combine() methods remain.
2015-06-24 Andy Buckley <andy.buckley@cern.ch>
* Adding workaround versions of binAt to all the Python histo
types (for some reason the direct mapping that works for bin(i)
produces a compile error for binAt(x) :-/
2015-06-23 Andy Buckley <andy.buckley@cern.ch>
* Renaming, tidying, completing, etc. the Python-mapped methods on Bin1D and Bin2D.
* Rename Python Histo2D mean, variance, etc. pair-returning
methods to xyMean, xyVariance, etc., to distinguish from Profile2D
mean, variance, etc.
* Add Python mappings of all the methods below.
* Add full set of {x,y}{Mean,Variance,StdDev,StdErr,RMS} to 1D and
2D binned distributions.
* Add optional includeoverflows=True argument to all binned AO
numEntries and effNumEntries.
* Fix type of numEntries to always be unsigned long.
2015-06-18 Andy Buckley <andy.buckley@cern.ch>
* Fix typos in Point3D Python mapping (accidentally trying to get
the ptr via _Point2D rather than _Point3D).
2015-06-13 Andy Buckley <andy.buckley@cern.ch>
* Adding an AnalysisObject::name() method, to return the last part
of the path. Mapped into a Python property.
* Adding an optional usestddev argument to mkScatter for profile
types, so the error bars can represent distribution width rather
than uncertainty on the mean. Mapped to Python.
2015-06-08 Andy Buckley <andy.buckley@cern.ch>
* Adding unpatterns arguments to Python read functions, and
auto-conversion from single strings and re.compile()d strs.
2015-06-04 Andy Buckley <andy.buckley@cern.ch>
* Add binAt(x,y) and binIndexAt(iglobal) Python methods for 2D
histos. Still want a way to get and pass a pair of bin indices, I
think.
* Adding includeoverflows optional args for Histo1D (eff)numEntries.
* Adding Rename Histo1D integral() methods as integral(),
integralRange(), and integralTo(), and mapping to Python.
2015-06-02 Andy Buckley <andy.buckley@cern.ch>
* Adding missing binAt and binIndexAt methods to Histo1D and
Profile1D, plus other minor Python mapping tweaks.
* Add a regex pattern match optional argument to the IO.read()
Python functions, for pre-emptive filtering.
2015-03-27 Andy Buckley <andy.buckley@cern.ch>
* Fix a harmless possibility to raise an FPE exception in the
BinSearcher. Thanks to Leif Lonnblad for the discovery, debug and
patch!
2015-03-19 Andy Buckley <andy.buckley@cern.ch>
* Bump version for 1.3.1 release.
2015-03-06 Andy Buckley <andy.buckley@cern.ch>
* Adding usefocus optional argument to some mkScatter functions, plus the Python bindings.
* Cleaning up some Python mappings of 2D histogram bin classes.
* Removing mappings of bin-level fill and scale operations in Python.
* Fix formatting and error handling in Python Bin and Dbn __repr__ methods.
* Add a -i/--in-place option pair on yodascale.
2015-02-05 Andy Buckley <andy.buckley@cern.ch>
* Convert script matching options to use re search rather than match.
* Adding matching options and verbose option to yodals.
2015-01-27 Andy Buckley <andy.buckley@cern.ch>
* Improvements and additions to ROOTCnv.h routines, particularly
to TProfile creation: thanks to Roman Lysak for advice.
2015-01-16 Andy Buckley <andy.buckley@cern.ch>
* Add convenience YODA/YODA.h header.
2015-01-15 Andy Buckley <andy.buckley@cern.ch>
* yodascale now uses PointMatcher and can normalize or multiply to
abs values or ref histos/bin ranges.
2015-01-05 Andy Buckley <andy.buckley@cern.ch>
* Adding yoda.matcher Python sub-package with PointMatcher
functionality. To be used in Professor 2.0 and in yodascale.
* Adding 'scat2' type to yodahist.
* Add match/unmatch args to all conversion scripts, via a new Python yoda.script_helpers function.
* Script updates, improved docstrings, and improved tab completion.
2014-12-10 Andy Buckley <andy.buckley@cern.ch>
* Add a yoda.plotting sub-module, based on matplotlib.
2014-12-03 Andy Buckley <andy.buckley@cern.ch>
* Small build improvements: cleaning test1.root from the yoda2root
test, and adding a make target & flag file for mktemplates in
pyext/yoda to make sure that it only gets run once.
2014-11-25 Andy Buckley <andy.buckley@cern.ch>
* Handle overflow filling in binned types without invoking an exception.
* Change inRange to have non-fuzzy comparison behaviour.
2014-11-11 Andy Buckley <andy.buckley@cern.ch>
* Improving/adding __div__ functions in Python for all binned types.
* Add std:: prefix to isinf() calls in BinSearcher.h.
2014-09-30 Andy Buckley <andy.buckley@cern.ch>
* 1.3.0 release!
* Use numEntries() rather than effNumEntries() when checking
consistency of inputs to efficiency() calculations -- the
effNumEntries of a set can be smaller than that of a strict
subset, surprisingly!
2014-09-17 Andy Buckley <andy.buckley@cern.ch>
* Small improvements to yodahist and yodaplot behaviours/UIs.
* Adding setX/Y/Z(val, err) methods to Point3D.
* Add an efficiency method for 2D histos.
* Hide fill and fillBin methods from Python mappings of bin types.
2014-09-01 Andy Buckley <andy.buckley@cern.ch>
* YODA 1.2.1 release!
2014-08-29 Andy Buckley <andy.buckley@cern.ch>
* Hide non-const access to bin objects from histogram users:
avoids potential for inconsistency between total dbns and in-range
bins.
* Bug in BinSearcher fixed by Peter Richardson: constructor
arguments were passed in the wrong order when constructing a
LinEstimator in cases where log binning wouldn't be allowed.
2014-08-26 Andy Buckley <andy.buckley@cern.ch>
* Add protection against / characters in histo names in yoda2root
(thanks to Will Bell for the report and suggested patch).
2014-08-17 Andy Buckley <andy.buckley@cern.ch>
* Add +=, -=, *-, /=, ++ and -- operators to Counter, along with
an (implicit) constructor from a double -- all for user
convenience so Counter can be used in lieu of a simple number.
2014-08-15 Andy Buckley <andy.buckley@cern.ch>
* YODA 1.2.0 release!
* Permit +-inf values to be filled into histograms; NaN fills will
still explicitly throw an exception.
* Add unit tests for Counter, Scatter1D, and Scatter2D, including
persistency.
* Adding YODA and FLAT format I/O for Scatter1D and Counter (as
far as currently possible -- FLAT Counter can't be read due to a
#item ambiguity, just like the one between the YODA format Point3D
and ProfileBin1D). To be continued...
2014-08-14 Andy Buckley <andy.buckley@cern.ch>
* Python mappings for Dbn0D and Counter, and other improvements.
* Adding val() and err() methods to Counter, and errW() and
relErrW() to all DbnXD types.
* Adding Scatter1D and Point1D types, with conversion from Counter
supported. Both Counter and Scatter1D still need to be supported
by YODA persistency.
2014-08-11 Andy Buckley <andy.buckley@cern.ch>
* Add ROOT version checking to configure. Thanks to Michael Grosse
for the report/request.
2014-08-05 Andy Buckley <andy.buckley@cern.ch>
* Remove all methods not specific about the axis to which they
refer, e.g. Histo1D::mean -> xMean. Also remove all related
aliases (a nightmare to maintain) and low/highEdge and midpoint
functions: use the proper xMin/Max/Mid from now on. This is a
significant compatibility breaking API change (and the decision
was not taken lightly) so will require a 2nd digit version change.
* Lots of adding xMin/Max etc. functions to C++ and Python bin/histo classes.
* Compiler pickiness fixes in BinSearcher.
* Improvement to linspace, avoiding fuzzyEquals and again making
sure that the end value is exact.
2014-07-23 Andy Buckley <andy.buckley@cern.ch>
* Fix to logspace: make sure that start and end values are exact,
not the result of exp(log(x)).
* Clean-up, minor improvements, and adding a test for BinSearcher and friends.
2014-07-19 Andy Buckley <andy.buckley@cern.ch>
* Various consistency improvements and minor bugfixes to Python
mapping utils and Dbn and Bin objects.
* Fix Axis2D::reset, which was resetting the total dbn and
outflows, but not the bins!!! Thanks to Ewen Gillies for the
report.
2014-07-18 Andy Buckley <andy.buckley@cern.ch>
* Add scaleX,Y,Z and scaleXYZ to Point and Scatter classes, and
deprecate less explicit/consistent Scatter2D/3D.scale method.
2014-07-17 Andy Buckley <andy.buckley@cern.ch>
* yodascale now writes out rescaled histograms and profiles rather than scatters.
* A few more improvements on Point2D/3D, adding x,y,zMin/Max function mappings.
* Add first version of a yodascale script, based on code from Simone Amoroso.
2014-07-16 Andy Buckley <andy.buckley@cern.ch>
* More Scatter and 2D histo interface improvement.
* Remove 'return *this' from Scatter2D/3D add and combine methods.
* Add unit test checks for 1D and 2D mkScatter functions.
* Improve Scatter2D/3D C++ and Python interfaces.
* Add Scatter3D Python mapping.
2014-07-15 Andy Buckley <andy.buckley@cern.ch>
* Add auto-parsing of yes/no/on/off/true/false as bools in the
Python ao.annotation() function.
* Add parsing of yodaplot styles from command line args and
analysis object annotations.
2014-07-12 Andy Buckley <andy.buckley@cern.ch>
* Fix infinite recursions in Python wrappers for Point2D and
Point3D, and make the Python Point3D interface more standard.
* Add yodaplot script for basic plotting, using pgfplots as a backend.
2014-07-10 Andy Buckley <andy.buckley@cern.ch>
* Add mkScatter(Scatter2D) and mkScatter(Scatter3D) functions and
Python mappings: this allows all AOs to be used as args to
mkScatter(...) without needing to check if they already are
scatters.
2014-07-02 Andy Buckley <andy.buckley@cern.ch>
* Set y value and/or error to 0 in mkScatter(Histo1D) if an
exception is thrown when calculating the appropriate values. Need
an optional param to control this error handling behaviour between
set-zero and skip-bin?
2014-07-01 Andy Buckley <andy.buckley@cern.ch>
* Add exception translation to the mkScatter functions.
* Add -m/-M match/unmatch options to yodacnv -- useful for
filtering histogram file contents in a YODA->YODA conversion.
2014-06-24 Andy Buckley <andy.buckley@cern.ch>
* Don't complain about merge assumptions if there is only one
object with that path name to be 'merged'
2014-06-17 Andy Buckley <andy.buckley@cern.ch>
* Adding explicit int cast in Python wrapping of numEntries functions.
2014-06-13 Andy Buckley <andy.buckley@cern.ch>
* Adding yodals script to list data file contents.
2014-06-11 David Grellscheid <David.Grellscheid@durham.ac.uk>
* pyext/yoda/Makefile.am: 'make distcheck' and out-of-source
builds should work now.
2014-06-10 Andy Buckley <andy.buckley@cern.ch>
* Fix use of the install command for bash completion installation on Macs.
2014-06-06 Andy Buckley <andy.buckley@cern.ch>
* YODA 1.1.0 release. Middle version number change to reflect API changes w.r.t 1.0.6.
* Adding unit tests against ref data for yodamerge in make check.
2014-06-04 Andy Buckley <andy.buckley@cern.ch>
* Fix silly typos in yodamerge which somehow made it past "make check" testing :-(
2014-06-02 Andy Buckley <andy.buckley@cern.ch>
* YODA 1.0.7 release. DO NOT USE: prefer 1.1.0, above.
2014-05-30 Andy Buckley <andy.buckley@cern.ch>
* Removing 'foreach' macro definition and using raw BOOST_FOREACH instead until C++11 is allowed.
* Adding pytest-p1d and pytest-p2d tests, and FLAT writing/reading in pytests.
* Tweaking WriterFLAT and adding ReaderFLAT functionality for 2D histos and profiles.
2014-05-30 Holger Schulz <hschulz@physik.hu-berlin.de>
* Some basic (FLAT) write-out capability for 2D histos
2014-05-29 Andy Buckley <andy.buckley@cern.ch>
* Improvements to the yodahist script, including support for 2D
histograms and input files.
* Adding bin edges constructors for all 1D and 2D histos in Python.
2014-05-22 Andy Buckley <andy.buckley@cern.ch>
* Improvements to Profile2D and Point2D interfaces in Python.
* Add a single-file at a time yodacnv multi-format converter
script (thanks to Andrii Verbytskyi for the suggestion).
2014-05-19 Andy Buckley <andy.buckley@cern.ch>
* Typo fixes in Profile2D YODA-format parsing: 2D histo tests now pass!
* Adding Python tests for Histo2D and Profile2D.
* Adding a YODA/Predicates.h header and using it in Axis2D bin edge construction.
* Enabling Profile2D writing in various Writers, and a bit of IO code tidying.
2014-05-17 Andy Buckley <andy.buckley@cern.ch>
* Disable writing out of Histo2D and Profile2D outflows for now,
while they are redesigned, and get 2D I/O working for the in-range
part.
2014-05-14 Andy Buckley <andy.buckley@cern.ch>
* Mapping the divide and efficiency functions into the Python
interface as class methods, including the __div__ special
function.
2014-05-13 Andy Buckley <andy.buckley@cern.ch>
* Add the AnalysisObject::type() method back in Python (even
though type(ao) is more Pythonic, this may be useful)
2014-05-06 Andy Buckley <andy.buckley@cern.ch>
* Add Profile2D YODA format writing, note need for Scatter format
change, add sumXY storage to both 2D histo types.
2014-05-03 Andy Buckley <andy.buckley@cern.ch>
* Adding YODA reader functionality for Histo2D and Profile2D, but
without outflows support yet.
2014-04-25 Andy Buckley <andy.buckley@cern.ch>
* Adding simple command line yodahist script for quick 1D
histogramming from plain text files, with weight support. More
development to come!
* Mapping linspace, logspace and a few stat functions into Python.
2014-04-24 Andy Buckley <andy.buckley@cern.ch>
* Fixes, script installation, and detailed numerical comparisons
in yodadiff.
2014-04-17 Andy Buckley <andy.buckley@cern.ch>
* Change AnalysisObject::annotations to return the list of
annotation keys rather than the map, since the previous behaviour
mapped very badly into Python.
2014-04-16 Andy Buckley <andy.buckley@cern.ch>
* Add special case handling for 2-arg use of x2y scripts where the
second arg is -, for stdin. This will be treated as writing out to
stdout, not converting two files one of which is stdin.
2014-04-15 Andy Buckley <andy.buckley@cern.ch>
* Adding a more portable version of getline to be used in the YODA
file parsing to avoid falling over on DOS-produced input files.
2014-04-14 Andy Buckley <andy.buckley@cern.ch>
* Adding the namespace protection workaround for Boost described
at http://www.boost.org/doc/libs/1_55_0/doc/html/foreach.html
2014-04-13 Andy Buckley <andy.buckley@cern.ch>
* Adding an assumed-equal-run-size, ratio-like merging heuristic
for Scatter2Ds to yodamerge, and renaming the --normalize-all flag
to --assume-normalized.
* Adding and installing a pkg-config data file for YODA.
* Rationalising (and fixing?) the yodamerge logic re. user &
normalization scalings, and making way for a Scatter2D merging
heuristic.
2014-03-10 Andy Buckley <andy.buckley@cern.ch>
* YODA 1.0.6 release.
2014-03-06 Andy Buckley <andy.buckley@cern.ch>
* Improvements to AnalysisObject annotation handling in Python.
* Adding rescaling arguments to yodamerge (and scale function to Python Scatter2D).
* Better documentation and consistency of Histo and Profile Python
wrappers, and removing some inappropriate attributes.
* Adding clone() and newclone() functions to all analysis object classes.
2014-02-28 Andy Buckley <andy.buckley@cern.ch>
* Cython mapping improvements, esp. adding numPoints/numBins
functions and better Scatter2D __repr__.
* Adding mapping of the mkScatter functions into Python (as
methods on Histo1D and Profile1D rather than the original free
functions, at least for now: some Python type-identifying
boilerplate is needed to make a single mkScatter function work in
Python)
2014-02-27 Leif Lönnblad <Leif.Lonnblad@thep.lu.se>
* Minor modifications to BinSearcher to avoid NaN's. The NaN's
were treated correctly before, but better to avoid them all
together.
2014-02-27 Andy Buckley <andy.buckley@cern.ch>
* Adding the generated pyext/yoda/rootcompat.cpp to the tarball
and sorting out the ROOT/Cython interface conditionals a bit more
sanely. Thanks to Oldrich Kepka for the bug report.
* Protecting yodamerge against input histograms with zero
integrals (thanks to Christian Bierlich for the bug report).
2014-02-14 Frank Siegert <frank.siegert@cern.ch>
* Fix race condition with mktemplates.
2014-02-12 David Grellscheid <david.grellscheid@dur.ac.uk>
* Fix bug in mktemplates code (thanks to Christian Johnson for the bug report).
2014-02-09 Andy Buckley <andy.buckley@cern.ch>
* Adding explicit include/generated dir creation to Python
extension build (thanks to Christian Johnson for the bug report).
2014-02-06 Andy Buckley <andy.buckley@cern.ch>
* 1.0.5 release!
2014-02-05 Andy Buckley <andy.buckley@cern.ch>
* Adding patches to ReaderFLAT and ReaderYODA use of Boost Spirit
which reduce the Boost version requirement from 1.47 ->
1.41. Thanks to Andrii Verbytskyi for the patch.
* Protect against invalid prefix value if the --prefix configure option is unused.
2014-02-04 Andy Buckley <andy.buckley@cern.ch>
* Adding copy assignment operators where missing, based on an
implementation in AnalysisObject which only copies rvalue paths
and titles if they are non-null.
2014-02-03 Andy Buckley <andy.buckley@cern.ch>
* Improving (i.e. increasing) bin edge overlap tolerance: 1e-10 relative was too tight.
2014-01-31 Andy Buckley <andy.buckley@cern.ch>
* Adding x/yMid etc. methods on Bin1D and 2D, and more related Python API improvements.
2014-01-28 Andy Buckley <andy.buckley@cern.ch>
* Adding missing fillBin methods to 1D and 2D Histo/Profile Python classes.
* Fixed yodamerge default output file name treatment.
* Avoid computing an unrecoverable error in Histo1D.__repr__
* Clean-ups and API improvements in Python IO functions.
* Adding more sumW,W2 and (eff)NumEntries attrs to Python objects.
2013-12-17 Andy Buckley <andy.buckley@cern.ch>
* Improved argument handling for x2y scripts.
2013-11-16 Andy Buckley <andy.buckley@cern.ch>
* Fix to build the Cython rootcompt extension .cpp on request.
2013-11-14 Andy Buckley <andy.buckley@cern.ch>
* Adding flags for the C++11 or C++0x standard if supported, cf. Rivet.
2013-10-24 Andy Buckley <andy.buckley@cern.ch>
* YODA 1.0.4 release.
* Supporting zsh completion via bash completion compatibility.
2013-10-21 Andy Buckley <andy.buckley@cern.ch>
* Removing unused internal iterator typedefs from Writer functions.
2013-10-18 Andy Buckley <andy.buckley@cern.ch>
* Adding a yodaenv.sh sourceable script to help with environment setup.
* Remove Scatters from being handled by yodamerge by blocking the
__add__ method fallback.
2013-10-09 Andy Buckley <andy.buckley@cern.ch>
* Improvements to yoda-config and command-line completion, for the
Rivet 2.0.0 release.
2013-10-09 Andy Buckley <andy.buckley@cern.ch>
* Version 1.0.3 release.
2013-10-04 Andy Buckley <andy.buckley@cern.ch>
* Cython mapping improvements.
* Adding some improved heuristics and a --normalize-all option to
yodamerge. Frank S is now happy again ;-)
2013-10-01 Andy Buckley <andy.buckley@cern.ch>
* Adding operator +, -, +=, -= Python mappings wherever possible
for Histo1/2D, Profile1/2D, and Scatter2D.
2013-09-26 Andy Buckley <andy.buckley@cern.ch>
* Cython is no longer needed by tarball users.
2013-09-25 Andy Buckley <andy.buckley@cern.ch>
* Unset path of returned histogram if those of the args to add()
and subtract() are difference.
2013-09-24 Andy Buckley <andy.buckley@cern.ch>
* Python mapping improvements.
2013-09-23 Andy Buckley <andy.buckley@cern.ch>
* Add the -avoid-version flag to libtool.
* Adding more add and subtract special methods in Python.
2013-09-22 Andy Buckley <andy.buckley@cern.ch>
* mkScatter schanged to use histo midpoints rather than focuses by
default for the point x value.
2013-08-14 Andy Buckley <andy.buckley@cern.ch>
* Version 1.0.2.
* Some exception message improvements and improving the protection
of cosmetic mean calculations in WriterYODA.
2013-07-12 Andy Buckley <andy.buckley@cern.ch>
* Adding ROOT detection in configure and otherwise updating Dave's
rootcompat module so that it'll compile. There might be an
inconvenient ROOT version dependency in the signature of one of
the PyROOT API functions that is used as a shim :-(
2013-06-17 Andy Buckley <andy.buckley@cern.ch>
* Adding yoda.m4 from James Robinson.
2013-06-06 Hendrik Hoeth <hendrik.hoeth@cern.ch>
* Improve "==" operator in Axis1D and Axis2D
2013-06-06 Andy Buckley <andy.buckley@cern.ch>
* Adding fillBin() methods to all 1D and 2D histos, and noting
that Bin types need a back-link to their axis to maintain
consistency.
* Release of version 1.0.1
2013-06-05 Andy Buckley <andy.buckley@cern.ch>
* Change the divide(Scatter, Scatter) behaviours to use the
midpoint of the num/denom bins rather than mean of foci for the
output point position (and hence errors, too).
* Adding a toIntegralEfficiencyHisto function.
* Adding another Histo1D::integral() function, this time from 0 ->
i, maybe including the underflow.
2013-06-04 Andy Buckley <andy.buckley@cern.ch>
* Updating the Cython version requirement to 0.18
2013-06-03 Andy Buckley <andy.buckley@cern.ch>
* Adding relErr functions to 1D and 2D histo and profile bins, and
being careful about div by zero.
* Improvements in error treatment in division (better handling of zeros).
* Renaming merge-histos to yodamerge and installing it (and
improving the usage string a bit).
2013-05-31 Andy Buckley <andy.buckley@cern.ch>
* Adding the Counter type, and ability to output it from the YODA writer.
* Adding numEntries and effNumEntries methods to 1D and 2D Histo
and Profile classes.
* Adding Dbn0D and using it to implement Dbn1D.
2013-05-30 Andy Buckley <andy.buckley@cern.ch>
* Fixing several nasty errors in argument ordering for
Point{1,2,3}D construction in Scatter addPoint functions.
* Adding abs(...) to the returned Dbn1D::variance(), to avoid
problems when negative weights produce negative variance. No, we
don't like this either: is there a more correct way?
* Fixing the efficiency(Histo1D, Histo1D) implementation,
cf. http://root.cern.ch/phpBB3/viewtopic.php?t=3753
* Adding mkScatter(Profile2D)
2013-05-29 Hendrik Hoeth <hendrik.hoeth@cern.ch>
* Adding a reader for FLAT files and a flat2yoda converter
2013-05-27 Andy Buckley <andy.buckley@cern.ch>
* Adding a yoda-completion file for bash.
2013-05-17 Andy Buckley <andy.buckley@cern.ch>
* Mapping HistoBin1D.relErr in Python.
* Adding a non-const points() accessor to Scatter2D.
2013-05-13 Andy Buckley <andy.buckley@cern.ch>
* Adding combined value+error setX/Y functions on Point2D.
* Adding HistoBin1D::relErr()
2013-04-23 Andy Buckley <andy.buckley@cern.ch>
* Adding Python output handling for single AOs and to be able to
use a "-" filename to mean stdout.
2013-04-12 Andy Buckley <andy.buckley@cern.ch>
* Releasing version 1.0.0 -- it seems stable enough.
2013-04-10 Andy Buckley <andy.buckley@cern.ch>
* Being more careful about adding -Wno-* flags to the C++ compiler
used to built the Cython extension lib.
2013-03-22 Andy Buckley <andy.buckley@cern.ch>
* Removing the use of svn:external to pull in Boost macros and
using a minimal local set instead.
* Using the nice Boost-finding macros from
https://github.com/tsuna/boost.m4 and tidying up configure.ac
2013-03-15 Andy Buckley <andy.buckley@cern.ch>
* Re-organising the C++ side of the auto-format I/O functions,
into a new IO header and separated from the Reader.h and
Writer.h. I'm tempted to say that users shouldn't really NEED to
ever directly touch the Reader and Writer objects...
* Adding auto-format read and write functions. I will probably
change the API. Python mappings have been provided, but the string
workarounds were too much of a pain with Cython 0.16 so I have
updated the Cython version requirement to 0.17 where it is
automatic and hence much cleaner.
2013-03-08 Andy Buckley <andy.buckley@cern.ch>
* Making the x2y converter scripts write a copy into the *current*
directory if only the input is specified.
2013-03-05 Andy Buckley <andy.buckley@cern.ch>
* Removing Plot entirely from YODA: it was an anomaly only added
to make plot file generation easy, but this is now done better via
StringIO (in new compare-histos/rivet-cmphistos).
* Removing the Plot from Cython... and soon from YODA itself:
we'll do this stuff manually and less hackily.
* Make Cython automatically add a copy of the original call
signature to each function's docstring.
2013-03-04 Andy Buckley <andy.buckley@cern.ch>
* Adding Plot mapping to Cython and improving the AO annotations handling in Python.
* Adding PLOT section writing to WriterFLAT (and WriterYODA,
although that might be a bad idea...)
* Adding aida2yoda and aida2flat converter scripts.
2013-02-02 David Mallows <dave.mallows@gmail.com>
* Adding support for Python >= 2.4 (was Python >= 2.6)
* Fixing miscellaneous warnings on GCC 4.1
2013-01-30 Andy Buckley <andy.buckley@cern.ch>
* Adding a points() method to the Python Scatter2D wrapper.
* Adding a virtual destructor to Bin.
2012-12-30 Andy Buckley <andy.buckley@cern.ch>
* Adding support for Boost.Range arguments and file format autodetection in Writer.
2012-11-24 Andy Buckley <andy.buckley@cern.ch>
* Bump version to 0.6beta0
* Adding more ROOT converters. Who knows how to make TProfiles
from scratch, but Histo1D and Scatter2D are covered, which should
be enough to get started with, at least.
2012-11-16 Andy Buckley <andy.buckley@cern.ch>
* Adding yoda-config
2012-11-16 Hendrik Hoeth <hendrik.hoeth@cern.ch>
* Adding WriterFLAT and yoda2flat
2012-11-16 Andy Buckley <andy.buckley@cern.ch>
* Adding YODA/ROOTCnv.h. for data object converter functions. Two
(untested) functions added for TH1 -> YODA.
* Adding toIntegralHisto(Histo1D&) function.
2012-11-15 Dave Mallows <dave.mallows@gmail.com>
* Commited numerous changes to Axis2D. Axis2D now uses BinSearcher as
with Axis1D.
2012-11-15 Andy Buckley <andy.buckley@cern.ch>
* Improving division and efficiency treatments, and allowing
arbitrary f(x), f(y), and flip transformations on Scatter2D.
2012-11-14 Andy Buckley <andy.buckley@cern.ch>
* Converting linspace, logspace, and their usage to place the nbins argument first.
2012-08-07 Andy Buckley <andy.buckley@cern.ch>
* Removing unused (beyond 2nd order) sumWXYZ counter from Dbn3D.
2012-08-07 Dave Mallows <dave.mallows@gmail.com>
* Converted Axis1D to use new Utils/BinSearcher.
2012-08-02 Dave Mallows <dave.mallows@gmail.com>
* Heavily refactored Cython bindings
* HistoBin1D, ProfileBin1D etc. now inherit from Bin1D[DBN]
* Temporarily removed Histo2D, Profile2D and Scatter3D mappings.
2012-07-23 Andy Buckley <andy.buckley@cern.ch>
* Installing scripts from bin dir, and making the yoda2aida interface nicer.
* Adding Cython mappings for Dbn3D and Profile2D, and other fixes/improvements.
2012-07-22 Andy Buckley <andy.buckley@cern.ch>
* Adding Cython mappings for Scatter3D and ProfileBin2D.
* Fixing more crap code legacy from old 2D plot implementation, this time in Scatter3D.
2012-07-19 Andy Buckley <andy.buckley@cern.ch>
* Adding stdErr for Histo2D + Python mapping, and more Cython improvements.
* Adding path/title-only AO constructors and making nice Python constructor for Histo2D.
* Cython mapping improvements & additions for Point3D + Scatter3D.
* Removing mixed symm/asymm constructors on Point*D & Scatter*D classes.
2012-07-12 Andy Buckley <andy.buckley@cern.ch>
* Reintroducing Profile2D and Scatter3D.
* Adding axis locking to Axis2D.
* Supporting Histo2D in WriterYODA.
2012-07-02 Andy Buckley <andy.buckley@cern.ch>
* More incremental progress toward a working 2D bin hash mechanism.
2012-05-03 Andy Buckley <andy.buckley@cern.ch>
* Adding nice constructor behaviours to the Histo1D and Profile2D
Python interfaces, and adding the mkScatter operation for
Profile1D.
* Adding more default constructors for analysis objects, to allow
member variable and STL container use without pointers.
2012-05-02 Andy Buckley <andy.buckley@cern.ch>
* A much simplified and more robust rewrite of the Axis1D class,
just using STL map in place of the hand-written bin edge caching.
* Improvements (I hope) to the binary search in Axis1D, and
providing an experimental default constructor for Histo1D.
2011-12-08 Hendrik Hoeth <hendrik.hoeth@cern.ch>
* ReaderYODA can now parse Histo1D and Profile1D flat files
2011-12-08 Andy Buckley <andy.buckley@cern.ch>
* Adding a Utils::ndarray object and using it to implement a
general Scatter<N> system, with generalised Point<N> and Error<N>
to boot.
2011-12-07 Hendrik Hoeth <hendrik.hoeth@cern.ch>
* Lots of cleanup
2011-12-07 Andy Buckley <andy.buckley@cern.ch>
* Mapping the Dbn1D and Dbn2D classes into Python.
* Adding an outflows() accessor to Histo2D.
* Writing out total dbn lines for Histo1D and Profile1D in the
YODA format, and now writing out the 'cross-terms' for Profile1D,
too.
* Properly adding Dbn1D accessors for Histo1D.
* Updating the Cython mappings to provide the totalDbn() methods
and add a placeholder mapping for Dbn2D. Completed mappings are
needed for Dbn{1,2,3}D and the Profile types.
* Adding totalDbn() accessors to data types.
2011-12-06 Andy Buckley <andy.buckley@cern.ch>
* Making Histo1D/2D::scaleW() write a ScaledBy annotation.
* Adding annotation-fetching methods with a default return value
argument to AnalysisObject.
* Adding normalize() methods to Histo1D/2D.
* Adding weighted RMS calculating methods to Dbn1D, Dbn2D and
Bin1D/2D.
2011-09-03 Dave Mallows <dave.mallows@gmail.com>
* Fixed ReaderAIDA: x-value and low y-error interchanged when filling
Scatter2D.
* Changed to Cython for Python bindings: Swig bindings were in need of
serious amounts of work. Cython should provide a means to provide more
Pythonic bindings to YODA. A minimal subset of ReaderAIDA, Scatter2D
and Point2D have been wrapped.
* Modified configure.ac, Makefile.am and pyext/Makefile.am to reflect
change to Cython. Added cython.m4 from python-efl (Part of the
enlightenment project; LGPL)
2011-08-31 Dave Mallows <dave.mallows@gmail.com>
* Fixed python tests by installing python extension to pyext/build
2011-08-23 Andy Buckley <andy@insectnation.org>
* Adding rebinning interface to Histo1D and Profile1D, and adding
a test (and a new test feature for output message formatting)
* Adding first implementation of 1D bin merging to Axis1D.
2011-08-22 Andy Buckley <andy@insectnation.org>
* Adding copy constructors and assignment operators to Histo1D,
Profile1D, and Scatter2D, and their respective bins/points.
* Remove use of sign(weight) in filling sum(w2) -- I think this
was an historical attempt based on a scaling axiom which turned
out to be inappropriate.
* Reworking the Bin1D inheritance and composition design so that
all bin types store a single distribution object -- a Dbn1D for
histo bins and a Dbn2D for profile bins.
2011-08-18 Andy Buckley <andy@insectnation.org>
* Removing the Profile1D -> ProfileBin1D friendship. This is very
heartening -- the fewer friend declarations we need, the more
indication that the class structure is not pathological! (Or that
we've just made everything public... but we haven't)
2011-08-15 Andy Buckley <andy@insectnation.org>
* Inlining all functions in HistoBin1D, ProfileBin1D, and
HistoBin2D.
* Converting Dbn2D to be composed of two Dbn1Ds and a
cross-term. Also tidying the interfaces of the 2D classes and the
scaleX/Y methods throughout, and adding Doxygen comments.
2011-08-12 Andy Buckley <andy@insectnation.org>
* Adding proper Doxygen structures and full descriptive comments
to Dbn2D.
* Adding the persistency state-setting constructors for Profile1D
and Dbn2D.
* Inlining lots of methods on Dbn1D. Same should be done for
Dbn2D, but first it needs to be reimplemented in terms of two
Dbn1Ds + the cross-term.
2011-08-11 Andy Buckley <andy@insectnation.org>
* Various typo fixes and comments relating to persistency
constructors, Histo2D slicing, etc.
* Changing the HistoBin1D state-setting constructors (aargh, these
should *not* have already existed) to take Dbn1D as an argument
rather than a long list of doubles.
2011-08-01 Andy Buckley <andy@insectnation.org>
* Adding tests to check that implicit construction of Weights
objects from literal doubles and ints works.
2011-07-28 Andy Buckley <andy@insectnation.org>
* Bumping version number to 0.4.0beta0 -- there have been
substantial changes recently and YODA is now in a state where it
should be interesting for outsiders to start playing with it.
* Templating the Axis1D on the distribution type to be used for
total and under/overflow statistics: Profile1D now has Dbn2D
objects handling its total and overflow statistics.
2011-07-26 Andy Buckley <andy@insectnation.org>
* Added a Histo1D::integral(index1, index2) method. Not sure how
or if to extend this to Profile1D.
* Implementing incomplete Scatter2D operator+ and operator-
functions.
2011-07-25 Andy Buckley <andy@insectnation.org>
* Adding a Weights class, designed to seamlessly replace
double-type weights and weighted moments with a named and
vectorised form.
2011-07-19 Andy Buckley <andy@insectnation.org>
* Add Profile1D and Scatter2D division operators.
* Add xMin/xMax synonyms to the Axis1D, cf. the bins.
2011-07-18 Andy Buckley <andy@insectnation.org>
* Add a first stab at a Histo1D/Histo1D division operator.
2011-07-10 Andy Buckley <andy@insectnation.org>
* Add construction of Histo1Ds from Profile1D and Histo1D, and
construction of Profile1Ds from those and Scatter2D.
2011-07-07 Andy Buckley <andy@insectnation.org>
* Add construction of a Histo1D from Scatter2D.
2011-06-15 Andy Buckley <andy@insectnation.org>
* Making the AIDA reader work, including reading of annotations
and a few tweaks to the simple type persistency system. Test histo
1b updated.
2011-06-12 Andy Buckley <andy@insectnation.org>
* Removing Histo1D::area
* Filling and using under/overflow and total db on Histo1D, and
adding boolean arg to integral, sumW, etc.
* Fixing for C++ change in behaviour of std::make_pair
* Adding addAnnotation, and mapping annotations to Python.
2011-02-22 Andy Buckley <andy@insectnation.org>
* Use distutils rather than setuptools for the Python interface
build.
* Renaming Bin, HistoBin and ProfileBin to be Bin1D, HistoBin1D,
ProfileBin1D. Bin is now a top-level abstract class with minimal
functionality to be shared between 1D and 2D bins.
2011-01-12 Andy Buckley <andy@insectnation.org>
* Type annotations in mkScatter
* Added many vector constructors and addPoint functions to
Scatter2D.
2011-01-11 Andy Buckley <andy@insectnation.org>
* Add lexical_cast support to annotation get and set functions.
* Write out annotations in AIDA format, and copy annotations in
mkScatter -- using a new AnalysisObject::setAnnotations method.
* Convert DPS output to use interim Scatter construction
* Make (unused) yoda.plot subpackage.
* Write out annotations in YODA format.
* Make Scatter2D representations of Histo1D and Profile1D.
* Write out Scatter2D objects in AIDA and YODA formats.
* Make Scatter2D and Point2D work. Add a few extra
methods... evolution and tweaking required.
2011-01-10 Andy Buckley <andy@insectnation.org>
* Add Boost checks and header includes. Not used yet.
* Hide Utils:: content from Doxygen and nvector -> Utils::nvector.
* Removing unused YAML stuff: we aren't going that way for
persistency anymore.
* Renaming Axis -> Axis1D
* Removing dead-end templated Scatter stuff.
* Move (generated) config files into the Config subdir.
* Move sortedvector and indexedset into the Utils dir.
* Move the "utils" directory and namespace to "Utils"
* Put the Doxyfile under configure control by moving it to
Doxyfile.in and using the @PACKAGE_VERSION@ token.
* Make Doxygen find the .icc file and hide functions with name _*
and in the YAML namespace.
* Removing the Binning argument and enum in favour of explicit bin
edge vectors, possibly produced explicitly via the MathUtils
linspace and logspace functions, or the new Axis::mkBinEdgesLin/Log
alias functions.
* Fixed Axis, Histo1D and Profile1D constructors, by adding a path
argument, passing the path and title args to the AnalysisObject
base constructor properly.
* Removed several old and unused files such as Tree.h
2011-01-09 Andy Buckley <andy@insectnation.org>
* Updating copyright comments to be valid into 2011.
* Persistency fixes, and changing the interface to use the annotated path.
* Using annotations for path and title.
* Adding tests of collection and iterator range AO writing.
* Adding static write functions on Writer*.h implementations to
avoid needing to make an explicit Writer object via the create()
functions.
* Rename Exception.h -> Exceptions.h
* Added AnnotationError.
* Re-enable persistency of collections with begin/end iterators.
2011-01-08 Andy Buckley <andy@insectnation.org>
* Enabling quiet compilation.
* More annotation functionality.
2011-01-07 Andy Buckley <andy@insectnation.org>
* Sorting out autoheaders to be more useful.
* Rewriting AIDA writer to use DPS representation (no reloading)
for Histo1D and Profile1D objects.
* Adding persistency system hooks, since RTTI just sucks too much.
* Renaming test files to have more meaningful names.
2010-12-10 Andy Buckley <andy@insectnation.org>
* Some tweaks to Axis, Bin, etc. to use the sortedvector. Seems to
be working! (I must be checking it wrongly...)
* Adding another candidate object for the axis bin container: a
sorted extension to STL std::vector with an insert method. This
will do as a development placeholder: a proper sorted & indexed
container may be substituted later.
* Fix test code: titles are no longer given as histogram
constructor arguments.
2010-11-21 Andy Buckley <andy@insectnation.org>
* Adding indexed set for holding bins on axes. Still not sure it's
what we want, as (I just realised) STL sets are iterator-immutable
because they are self-keyed and changes to elements would also
change their sorting.
2010-09-19 Andy Buckley <andy@insectnation.org>
* Restarting ChangeLog contributions! Many changes in the huge
time since last update... activity on YODA has renewed and we have
a better picture of the distinctive features we require. New idea:
named weight vector filling, allowing "parallel" histograms for
various event weight variations. I/O remains an awkward issue,
especially since the classes are now much richer than they used to
be, and don't know about paths. Output can be easily put on top:
not an issue... and we can probably do something with
pickling. But reading in from C++?
2008-09-16 Andy Buckley <andy@insectnation.org>
* Moved duplicate Histo1D/Profile1D code on to Axis, making Axis a
templated class at the same time.
2008-09-12 Andy Buckley <andy@insectnation.org>
* Started work on a little plotting tool, initially for Herwig++
parton pT cut testing, but incrementally enhancing it to be a
command-line quick plotter seems like a good idea.
* Added some more test programs... working towards a proper test
suite.
* Added "no path & title" constructors - you don't always want to
write out the histo, since sometimes it's just a good way to
gather statistics.
* Fixed YODA mapping to allow use of vectors of bins as Python
lists.
* Added Profile1D functionality.
* Fixed Dbn1D to use sign(weight) as part of the "w**2" measure,
so that negative weights behave themselves.
2008-05-23 Andy Buckley <andy@insectnation.org>
* Added Dbn1D class to centralise the calculation of statistics
from unbounded, unbinned, weighted distributions.
2008-05-15 Andy Buckley <andy@insectnation.org>
* Added Profile1D class.
* Fixed NaN errors from zero weights.
2008-04-14 Andy Buckley <andy@insectnation.org>
* Python SWIG interface now compiles and can be used: the subtlety
that was breaking it was that SWIG has to be prodded in pretty
non-obvious ways to make std::vectors of classes without
default (no-arg) constructors. See
http://osdir.com/ml/programming.swig/2004-04/msg00011.html for
about the only reference to this to be found anywhere!
* Basic AIDA writer now available - it doesn't yet output all the
necessary information though, especially not for merging parallel
runs.
diff --git a/include/YODA/Axis1D.h b/include/YODA/Axis1D.h
--- a/include/YODA/Axis1D.h
+++ b/include/YODA/Axis1D.h
@@ -1,606 +1,606 @@
#ifndef YODA_Axis1D_h
#define YODA_Axis1D_h
#include "YODA/AnalysisObject.h"
#include "YODA/Exceptions.h"
#include "YODA/Bin.h"
#include "YODA/Utils/MathUtils.h"
#include "YODA/Utils/BinSearcher.h"
#include <limits>
#include <string>
namespace YODA {
/// @brief 1D bin container
///
/// This class handles most of the low-level operations on an axis of bins
/// arranged in a 1D line (including gaps).
template <typename BIN1D, typename DBN>
class Axis1D {
public:
/// Typedefs
//@{
/// Bin type
typedef BIN1D Bin;
/// A vector containing 1D bins. Not used for searching.
typedef typename std::vector<Bin> Bins;
//@}
/// @name Constructors
//@{
/// Empty constructor
Axis1D()
: _locked(false)
{ }
/// Constructor accepting a list of bin edges
Axis1D(const std::vector<double>& binedges)
: _locked(false)
{
addBins(binedges);
}
/// @brief Constructor accepting a vector of bins.
///
/// Note that not only dimensions of these bins will be set,
/// all the contents of the bins will be copied across, including
/// the statistics
Axis1D(const std::vector<BIN1D>& bins)
: _locked(false)
{
addBins(bins);
}
/// Constructor with the number of bins and the axis limits
/// @todo Rewrite interface to use a pair for the low/high
Axis1D(size_t nbins, double lower, double upper)
: _locked(false)
{
addBins(linspace(nbins, lower, upper));
}
/// @brief Constructor accepting a vector of bins.
///
/// Note that not only dimensions of these bins will be set,
/// all the contents of the bins will be copied across, including
/// the statistics
Axis1D(const Bins& bins, const DBN& dbn_tot, const DBN& dbn_uflow, const DBN& dbn_oflow)
: _dbn(dbn_tot), _underflow(dbn_uflow), _overflow(dbn_oflow), _locked(false)
{
addBins(bins);
}
/// @name Statistics accessor functions
//@{
/// Get the number of bins on the axis
size_t numBins() const {
return bins().size();
}
/// Return a vector of bins (const)
const Bins& bins() const {
return _bins;
}
/// Return a vector of bins (non-const)
Bins& bins() {
return _bins;
}
/// Return the lowest-value bin edge on the axis
double xMin() const {
if (numBins() == 0) throw RangeError("This axis contains no bins and so has no defined range");
return bins().front().xMin();
}
/// Return the highest-value bin edge on the axis
double xMax() const {
if (numBins() == 0) throw RangeError("This axis contains no bins and so has no defined range");
return bins().back().xMax();
}
/// Return all the Nbin+1 bin edges on the axis
///
/// @note This only returns the finite edges, i.e. -inf and +inf are removed
/// @todo Make the +-inf stripping controllable by a default-valued bool arg
std::vector<double> xEdges() const {
std::vector<double> rtn(_binsearcher.edges().begin()+1, _binsearcher.edges().end()-1);
return rtn;
}
/// Return a bin at a given index (non-const)
BIN1D& bin(size_t index) {
if (index >= numBins()) throw RangeError("YODA::Histo1D: index out of range!");
return _bins[index];
}
/// Return a bin at a given index (const)
const BIN1D& bin(size_t index) const {
if (index >= numBins()) throw RangeError("YODA::Histo1D: index out of range!");
return _bins[index];
}
/// Returns an index of a bin at a given coord, -1 if no bin matches
ssize_t binIndexAt(double coord) const {
// Yes, this is robust even with an empty axis: there's always at least one outflow
return _indexes[_binsearcher.index(coord)];
}
/// Return a bin at a given coordinate (non-const)
BIN1D& binAt(double x) {
const ssize_t index = binIndexAt(x);
if (index == -1) throw RangeError("There is no bin at the specified x");
return bin(index);
}
/// Return a bin at a given coordinate (const)
const BIN1D& binAt(double x) const {
const ssize_t index = binIndexAt(x);
if (index == -1) throw RangeError("There is no bin at the specified x");
return bin(index);
}
/// Return the total distribution (const)
const DBN& totalDbn() const {
return _dbn;
}
/// Return the total distribution (non-const)
DBN& totalDbn() {
return _dbn;
}
/// Set the total distribution: CAREFUL!
void setTotalDbn(const DBN& dbn) {
_dbn = dbn;
}
/// Return underflow (const)
const DBN& underflow() const {
return _underflow;
}
/// Return underflow (non-const)
DBN& underflow() {
return _underflow;
}
/// Set the underflow distribution: CAREFUL!
void setUnderflow(const DBN& dbn) {
_underflow = dbn;
}
/// Return overflow (const)
const DBN& overflow() const {
return _overflow;
}
/// Return overflow (non-const)
DBN& overflow() {
return _overflow;
}
/// Set the overflow distribution: CAREFUL!
void setOverflow(const DBN& dbn) {
_overflow = dbn;
}
//@}
/// @name Modifiers and helpers
//@{
/// Reset all the bin statistics on the axis
void reset() {
_dbn.reset();
_underflow.reset();
_overflow.reset();
for (Bin& bin : _bins) bin.reset();
_locked = false;
}
/// Set the axis lock state
void _setLock(bool locked) {
_locked = locked;
}
/// Get lists of Nbins+1 edges, and Nbins+2 indices (-1 for gaps) from the current binning
/// @todo Push this into an abstract Binning object in v2?
/// @todo Should be a const ref arg?
std::pair< std::vector<double>, std::vector<long> > _mk_edges_indexes(Bins& bins) const {
std::vector<double> edges; edges.reserve(bins.size()+1); // Nbins+1 edges
std::vector<long> indexes; edges.reserve(bins.size()+2); // Nbins + 2*outflows
// Sort the bins
std::sort(bins.begin(), bins.end());
// Keep a note of the last high edge
double last_high = -std::numeric_limits<double>::infinity();
// Check for overlaps
for (size_t i = 0; i < bins.size(); ++i) {
Bin& currentBin = bins[i];
const double new_low = currentBin.xMin();
const double reldiff = (new_low - last_high) / currentBin.xWidth();
if (reldiff < -1e-3) { //< @note If there is a "large" negative gap (i.e. overlap), throw an exception
std::stringstream ss;
ss << "Bin edges overlap: " << last_high << " -> " << new_low;
throw RangeError(ss.str());
} else if (reldiff > 1e-3) { //< @note If there is a "large" positive gap, create a bin gap
indexes.push_back(-1); // First index will be for underflow
edges.push_back(new_low); // Will include first edge
}
// Bins check that they are not zero or negative width. It's okay for
// them to throw an exception here, as we haven't changed anything yet.
indexes.push_back(i);
edges.push_back(currentBin.xMax());
last_high = currentBin.xMax();
}
indexes.push_back(-1); // Overflow
return std::make_pair(edges, indexes);
}
/// Merge together the bin range with indices from @a from to @a to, inclusive.
/// Merge a series of bins, between the bins identified by indices @a from and @a to
void mergeBins(size_t from, size_t to) {
// Correctness checking
if (from >= numBins())
throw RangeError("Initial merge index is out of range");
if (to >= numBins())
throw RangeError("Final merge index is out of range");
if (from > to)
throw RangeError("Final bin must be greater than or equal to initial bin");
if (_gapInRange(from, to))
throw RangeError("Bin ranges containing gaps cannot be merged");
if (from == to)
return; // nothing to be done
Bin& b = bin(from);
for (size_t i = from + 1; i <= to; ++i)
b.merge(_bins[i]);
eraseBins(from+1, to);
}
/// @brief Merge every group of @a n bins, from start to end inclusive
///
/// If the number of bins is not a multiple of @a n, the last @a m < @a n
/// bins on the RHS will also be merged, as the closest possible approach to
/// factor @n rebinning everywhere.
void rebinBy(unsigned int n, size_t begin=0, size_t end=UINT_MAX) {
if (n < 1) throw UserError("Rebinning requested in groups of 0!");
for (size_t m = begin; m < end; ++m) {
if (m > numBins()) break;
const size_t myend = (m+n-1 < numBins()) ? m+n-1 : numBins()-1;
if (myend > m) {
mergeBins(m, myend);
end -= myend-m; //< reduce upper index by the number of removed bins
}
}
}
/// @brief Overloaded alias for rebinBy
void rebin(unsigned int n, size_t begin=0, size_t end=UINT_MAX) { rebinBy(n, begin, end); }
/// @brief Rebin to the given list of bin edges
void rebinTo(const std::vector<double>& newedges) {
if (newedges.size() < 2)
throw UserError("Requested rebinning to an edge list which defines no bins");
const Utils::BinSearcher newbs(newedges);
const std::vector<double> eshared = newbs.shared_edges(_binsearcher);
if (eshared.size() != newbs.size())
throw BinningError("Requested rebinning to incompatible edges");
// std::cout << "Before merging" << std::endl;
// for (double x : _binsearcher.edges()) std::cout << x << std::endl;
// If the new min finite edge isn't the same, merge it into the underflow
// NB. Edge search match the *next* bin, so step back one unit... and note these are BinSearcher indices, i.e. i+1
if (!fuzzyEquals(xMin(), newedges.front())) {
const size_t kmatch = _binsearcher.index(newedges.front()) - 1;
mergeBins(0, kmatch-1);
_underflow += bin(0).dbn();
eraseBin(0);
}
// std::cout << "Merged start bins" << std::endl;
// for (double x : _binsearcher.edges()) std::cout << x << std::endl;
// Now the same for the overflow
if (!fuzzyEquals(xMax(), newedges.back())) {
const size_t kmatch = _binsearcher.index(newedges.back()) - 1;
// std::cout << newedges.back() << " -> " << kmatch << " .. " << _bins.size()-1 << " / " << numBins() << std::endl;
mergeBins(kmatch, _bins.size()-1);
_overflow += bin(_bins.size()-1).dbn();
eraseBin(_bins.size()-1);
}
// std::cout << "Merged end bins" << std::endl;
// for (double x : _binsearcher.edges()) std::cout << x << std::endl;
// Now merge the in-range bins
size_t jcurr = 0;
for (size_t i = 1; i < newedges.size(); ++i) { //< we already know that i=0 matches (until we support merging into overflows)
const size_t kmatch = _binsearcher.index(newedges.at(i)) - 1; //< Will match the *next* bin, so step back one unit... and note these are BinSearcher indices
assert(kmatch >= jcurr+1);
mergeBins(jcurr, kmatch-1);
jcurr += 1; //< The next bin to be merged, in the new numbering
}
// std::cout << "After merging" << std::endl;
// for (double x : _binsearcher.edges()) std::cout << x << std::endl;
}
/// @brief Overloaded alias for rebinTo
void rebin(const std::vector<double>& newedges) { rebinTo(newedges); }
/// Add a bin, passed explicitly
void addBin(const Bin& b) {
/// @todo Efficiency?
Bins newBins(_bins);
newBins.push_back(b);
_updateAxis(newBins);
}
/// Add a bin, providing its low and high edge
void addBin(double low, double high) {
addBin(Bin(low, high));
}
/// Add a contiguous set of bins to an axis, via their list of edges
void addBins(const std::vector<double>& binedges) {
Bins newBins(_bins);
if (binedges.size() == 0) return;
double low = binedges.front();
for (size_t i = 1; i < binedges.size(); ++i) {
const double high = binedges[i];
assert(high>low); // Make sure binedges are meaningful
newBins.push_back(Bin(low, high));
low = high;
}
_updateAxis(newBins);
}
/// Add a list of bins as pairs of lowEdge, highEdge
void addBins(const std::vector<std::pair<double, double> >& binpairs) {
// Make a copy of the current binning
Bins newBins(_bins);
// Iterate over given bins
for (size_t i = 0; i < binpairs.size(); ++i) {
std::pair<double, double> b = binpairs[i];
newBins.push_back(Bin(b.first, b.second));
}
_updateAxis(newBins);
}
/// Add a list of Bin objects
void addBins(const Bins& bins) {
Bins newBins(_bins);
for (const Bin& b : bins) newBins.push_back(b);
_updateAxis(newBins);
}
/// Remove a bin
void eraseBin(const size_t i) {
// Might as well erase from the internal bins, as we can guarantee
// consistency.
if (i >= numBins())
throw RangeError("Bin index is out of range");
const bool wasLocked = _locked;
_locked = false;
_bins.erase(_bins.begin() + i);
_updateAxis(_bins);
_locked = wasLocked;
}
/// Remove a bin range
void eraseBins(const size_t from, const size_t to) {
if (from >= numBins())
throw RangeError("Initial index out of range");
if (to >= numBins())
throw RangeError("Final index out of range");
if (from > to)
throw RangeError("Final index is less than initial index");
const bool wasLocked = _locked;
_locked = false;
_bins.erase(_bins.begin() + from, _bins.begin() + to + 1);
_updateAxis(_bins);
_locked = wasLocked;
}
/// Scale the size of an axis by a factor
// @todo What if somebody passes in negative scalefactor? (test idea)
void scaleX(double scalefactor) {
_dbn.scaleX(scalefactor);
_underflow.scaleX(scalefactor);
_overflow.scaleX(scalefactor);
for (size_t i = 0; i < _bins.size(); ++i)
_bins[i].scaleX(scalefactor);
_updateAxis(_bins);
}
/// Scale the amount of fills by a factor
void scaleW(double scalefactor) {
_dbn.scaleW(scalefactor);
_underflow.scaleW(scalefactor);
_overflow.scaleW(scalefactor);
for (size_t i = 0; i < _bins.size(); ++i) _bins[i].scaleW(scalefactor);
}
//@}
/// @name Comparisons to other Axis objects
//@{
bool sameBinning(const Axis1D& other) const {
if (numBins() != other.numBins()) return false;
if (_indexes != other._indexes) return false;
return _binsearcher.same_edges(other._binsearcher);
}
bool subsetBinning(const Axis1D& other) const {
const int ndiff = numBins() - other.numBins();
if (ndiff == 0) return sameBinning(other);
/// @todo Do we require the finite axis begin/end to be the same?
return !_binsearcher.shared_edges(other._binsearcher).empty();
}
//@}
/// @name Operators
//@{
/// Check if two of the Axis have the same binning, within numeric tolerance
bool operator == (const Axis1D& other) const {
return sameBinning(other);
}
/// Check if the binning of two of the Axis is different
bool operator != (const Axis1D& other) const {
return ! operator == (other);
}
/// Add two axes together
Axis1D<BIN1D,DBN>& operator += (const Axis1D<BIN1D,DBN>& toAdd) {
if (*this != toAdd) throw LogicError("YODA::Histo1D: Cannot add axes with different binnings.");
for (size_t i = 0; i < _bins.size(); ++i) {
_bins[i] += toAdd.bins().at(i);
}
_dbn += toAdd._dbn;
_underflow += toAdd._underflow;
_overflow += toAdd._overflow;
return *this;
}
/// Subtract two axes
Axis1D<BIN1D,DBN>& operator -= (const Axis1D<BIN1D,DBN>& toSubtract) {
if (*this != toSubtract) throw LogicError("YODA::Histo1D: Cannot add axes with different binnings.");
for (size_t i = 0; i < _bins.size(); ++i) {
_bins[i] -= toSubtract.bins().at(i);
}
_dbn -= toSubtract._dbn;
_underflow -= toSubtract._underflow;
_overflow -= toSubtract._overflow;
return *this;
}
//@}
private:
/// Sort the given bins vector, and regenerate the bin searcher
//
/// The bin searcher is purely for searching, and is generated from
/// the bins list only.
void _updateAxis(Bins& bins) {
// Ensure that axis is not locked
if (_locked) {
- throw LockError("Attempting to update a locked axis");
+ throw LockError("Attempting to update a locked 1D axis");
}
// Get the new cuts and indexes (throws if overlaps), and set them on the searcher
const std::pair< std::vector<double>, std::vector<long> > es_is = _mk_edges_indexes(bins);
_binsearcher = Utils::BinSearcher(es_is.first);
_indexes = es_is.second;
_bins = bins;
}
/// Check if there are any gaps in the axis' binning between bin indices @a
/// from and @a to, inclusive.
bool _gapInRange(size_t ifrom, size_t ito) const {
if (ifrom == ito) return false;
assert(ito < numBins() && ifrom < ito);
/// @todo Why do we need to re-find the bin indices?
const size_t from_ix = _binsearcher.index(bin(ifrom).xMid());
const size_t to_ix = _binsearcher.index(bin(ito).xMid());
// std::cout << ifrom << " vs. " << from_ix << std::endl;
// std::cout << ito << " vs. " << to_ix << std::endl;
for (size_t i = from_ix; i <= to_ix; i++)
// for (size_t i = ifrom; i <= ito; i++)
if (_indexes[i] == -1) return true;
return false;
}
private:
/// @name Data structures
//@{
/// Bins vector
Bins _bins;
/// Total distribution
DBN _dbn;
/// Under- and overflows
DBN _underflow;
DBN _overflow;
// Binsearcher, for searching bins
Utils::BinSearcher _binsearcher;
// Mapping from binsearcher indices to bin indices (allowing gaps)
std::vector<long> _indexes;
/// Whether modifying bin edges is permitted
bool _locked;
//@}
};
/// Add the statistics on two axes.
template <typename BIN1D, typename DBN>
inline Axis1D<BIN1D,DBN> operator + (const Axis1D<BIN1D,DBN>& first, const Axis1D<BIN1D,DBN>& second) {
Axis1D<BIN1D,DBN> tmp = first;
tmp += second;
return tmp;
}
/// Subtract the statistics on two axis.
template <typename BIN1D, typename DBN>
inline Axis1D<BIN1D,DBN> operator - (const Axis1D<BIN1D,DBN>& first, const Axis1D<BIN1D,DBN>& second) {
Axis1D<BIN1D,DBN> tmp = first;
tmp -= second;
return tmp;
}
}
#endif
diff --git a/include/YODA/Axis2D.h b/include/YODA/Axis2D.h
--- a/include/YODA/Axis2D.h
+++ b/include/YODA/Axis2D.h
@@ -1,661 +1,663 @@
#ifndef YODA_Axis2D_h
#define YODA_Axis2D_h
#include "YODA/AnalysisObject.h"
#include "YODA/Exceptions.h"
#include "YODA/Bin.h"
#include "YODA/Utils/MathUtils.h"
#include "YODA/Utils/Predicates.h"
#include "YODA/Utils/BinSearcher.h"
#include <limits>
#include <string>
namespace YODA {
/// @brief 2D bin container
///
/// This class handles most of the low-level operations on an axis of bins
/// arranged in a 2D grid (including gaps).
template <typename BIN2D, typename DBN>
class Axis2D {
public:
/// Typedefs
//@{
/// Bin type
typedef BIN2D Bin;
/// A vector containing 2D bins. Not used for searching.
typedef typename std::vector<Bin> Bins;
// Distinguishing between single edges and edge pairs (and pairs of pairs) is useful
typedef std::vector<double> Edges;
typedef std::pair<double, double> EdgePair1D;
typedef std::pair<EdgePair1D, EdgePair1D> EdgePair2D;
typedef std::vector<EdgePair2D> EdgePair2Ds;
// Outflow distribution lists: see outflow(int, int)
typedef std::vector<DBN> Outflow;
typedef std::vector<Outflow> Outflows;
//@}
/// @name Constructors
//@{
// Empty constructor
Axis2D()
: _locked(false)
{
reset();
}
/// A constructor with specified x and y axis bin cuts.
Axis2D(const Edges& xedges, const Edges& yedges)
: _locked(false)
{
addBins(xedges, yedges);
reset();
}
/// Constructor accepting X/Y ranges and number of bins
/// on each of the axis. Both axes are divided linearly.
Axis2D(size_t nbinsX, const std::pair<double,double>& rangeX,
size_t nbinsY, const std::pair<double,double>& rangeY)
: _locked(false)
{
addBins(linspace(nbinsX, rangeX.first, rangeX.second),
linspace(nbinsY, rangeY.first, rangeY.second));
reset();
}
/// Constructor accepting a list of bins
- Axis2D(const Bins& bins) {
+ Axis2D(const Bins& bins)
+ : _locked(false)
+ {
addBins(bins);
reset();
}
/// State-setting constructor for persistency
Axis2D(const Bins& bins,
const DBN& totalDbn,
const Outflows& outflows)
: _dbn(totalDbn), _outflows(outflows),
_locked(false) // Does this make sense?
{
if (_outflows.size() != 8) {
throw Exception("Axis2D outflow containers must have exactly 8 elements");
}
addBins(bins);
}
void reset() {
_dbn.reset();
_outflows.assign(8, Outflow());
for (Bin& bin : _bins) bin.reset();
_locked = false;
}
/// Get the number of bins.
size_t numBins() const {
return _bins.size();
}
/// Get the number of bins on the x-axis. This is only sensible for
/// perfectly regular gridded bins. For irregular binnings, this is
/// the number of cuts that were necessary to grid the data.
size_t numBinsX() const {
return _nx;
}
/// Get the number of bins on the y-axis. This is only sensible for
/// perfectly regular gridded bins. For irregular binnings, this is
/// the number of cuts that were necessary to grid the data.
size_t numBinsY() const {
return _ny;
}
//@}
//
/// @name Statistics accessor functions
//@{
/// @brief Get the outflow by x-index and y-index (non-const version)
///
/// Indices are -1 = below range, 0 = in range, +1 = above range, e.g. (+1,
/// -1) is in the "bottom right" position by being greater than the greatest
/// x-edge and less than the lowest y-edge.
///
Outflow& outflow(int ix, int iy) {
return _outflows[_outflowIndex(ix, iy)];
}
/// @brief Get the outflow by x-index and y-index (const version)
///
/// Indices are -1 = below range, 0 = in range, +1 = above range, e.g. (+1,
/// -1) is in the "bottom right" position by being greater than the greatest
/// x-edge and less than the lowest y-edge.
///
const Outflow& outflow(int ix, int iy) const {
return _outflows[_outflowIndex(ix, iy)];
}
/// Scale each bin as if the entire x-axis had been scaled by this factor.
void scaleX(double xscale) {
scaleXY(xscale, 1.0);
}
/// Scale each bin as if the entire y-axis had been scaled by this factor.
void scaleY(double yscale) {
scaleXY(1.0, yscale);
}
/// Scale each bin as if the entire x and y-axes had been scaled by
/// their respective factors.
void scaleXY(double sx, double sy) {
_dbn.scaleXY(sx, sy);
/// @todo Reinstate when C++11 allowed in API
// for (Outflow& outflow : _outflows)
// for (DBN& dbn : outflow)
// dbn.scaleXY(sx, sy);
for (size_t io = 0; io < _outflows.size(); ++io) {
Outflow& outflow = _outflows[io];
for (size_t id = 0; id < outflow.size(); ++id) {
DBN& dbn = outflow[id];
dbn.scaleXY(sx, sy);
}
}
/// @todo Reinstate when C++11 allowed in API
// for (Bin& bin : _bins)
// bin.scaleXY(sx, sy);
for (size_t ib = 0; ib < _bins.size(); ++ib) _bins[ib].scaleXY(sx, sy);
_updateAxis(_bins);
}
/// Rescale as if all fill weights had been different by factor @a
/// scalefactor.
void scaleW(double scalefactor) {
_dbn.scaleW(scalefactor);
/// @todo Reinstate when C++11 allowed in API
// for (Outflow& outflow : _outflows)
// for (DBN& dbn : outflow)
// dbn.scaleW(scalefactor);
for (size_t io = 0; io < _outflows.size(); ++io) {
Outflow& outflow = _outflows[io];
for (size_t id = 0; id < outflow.size(); ++id) {
DBN& dbn = outflow[id];
dbn.scaleW(scalefactor);
}
}
/// @todo Reinstate when C++11 allowed in API
// for (Bin& bin : _bins)
// bin.scaleW(scalefactor);
for (size_t ib = 0; ib < _bins.size(); ++ib) _bins[ib].scaleW(scalefactor);
_updateAxis(_bins);
}
/// Remove the bin at the given index. If many bins need to be
/// removed, prefer eraseBins(vector[size_t] &) over many calls to this,
/// as recreating the binhash is comparatively expensive.
void eraseBin(size_t i) {
if (i >= numBins())
throw RangeError("Bin index is out of range");
// Temporarily unlock the axis during the update
_bins.erase(_bins.begin() + i);
_updateAxis(_bins);
}
/// Erase a rectangle of bins.
void eraseBins(const size_t from, const size_t to) {
if (from >= numBins())
throw RangeError("Initial bin index is out of range");
if (from >= numBins())
throw RangeError("Final bin index is out of range");
Bin& fromBin = bin(from);
Bin& toBin = bin(to);
eraseBins(std::make_pair(fromBin.xMin(), toBin.xMax()),
std::make_pair(fromBin.yMin(), toBin.yMax()));
}
/// Erase bins in an x- and y-range. Any bins which lie entirely within the
/// region are deleted. If any part of the bin lies outside this
/// range, the bin remains, so this has similar behaviour to select
/// tools in vector graphics GUI packages.
///
/// @todo How to test this?
void eraseBins(const std::pair<double, double>& xrange,
const std::pair<double, double>& yrange)
{
size_t xiLow = _binSearcherX.index(xrange.first) - 1;
size_t xiHigh = _binSearcherX.index(xrange.second) - 1;
size_t yiLow = _binSearcherY.index(yrange.first) - 1;
size_t yiHigh = _binSearcherY.index(yrange.second) - 1;
/// @todo Beware the specialisation problems with vector<bool>...
std::vector<bool> deleteMask(numBins(), false);
for (size_t yi = yiLow; yi < yiHigh; yi++) {
for (size_t xi = xiLow; xi < xiHigh; xi++) {
ssize_t i = _indexes[_index(_nx, xi, yi)];
if (i == -1 || deleteMask[i]) continue;
if (bin(i).fitsInside(xrange, yrange)) deleteMask[i] = true;
}
}
// Now we just update
eraseBins(deleteMask);
}
/// Erase using a vector<bool>, where true represents that a bin
/// will be deleted, and false means it will be kept.
void eraseBins(const std::vector<bool>& deleteMask) {
Bins newBins;
for (size_t i = 0; i < numBins(); i++)
if (!deleteMask[i]) newBins.push_back(bins(i));
_update(newBins);
}
/// Merge together the bin range with indices from @a from to @a to, inclusive.
/// Merge a series of bins, between the bins identified by indices @a from and @a to
void mergeBins(size_t from, size_t to) {
// Correctness checking
if (from >= numBins())
throw RangeError("Initial merge index is out of range");
if (to >= numBins())
throw RangeError("Final merge index is out of range");
if (from > to)
throw RangeError("Final bin must be greater than or equal to initial bin");
if (_gapInRange(from, to))
throw RangeError("Bin ranges containing gaps cannot be merged");
if (from == to)
return; // nothing to be done
Bin& b = bin(from);
for (size_t i = from + 1; i <= to; ++i)
b.merge(_bins[i]);
eraseBins(from+1, to);
}
/// Rebin with the same rebinning factor @a n in x and y
void rebin(unsigned int n) {
rebinXY(n, n);
}
/// Rebin with separate rebinning factors @a nx, @a ny in x and y
void rebinXY(unsigned int nx, unsigned int ny) {
rebinX(nx);
rebinY(ny);
}
/// Rebin in x by factor @a nx
void rebinX(unsigned int nx) {
/// @todo WRITE THIS!
}
/// Rebin in y by factor @a ny
void rebinY(unsigned int ny) {
/// @todo WRITE THIS!
}
/// Set the axis lock state
/// @todo Remove? Should not be public
void _setLock(bool locked) { _locked = locked; }
/// Return the lowest-valued bin edge along the x-axis
double xMin() const { return _xRange.first; }
/// Return the highest-valued bin edge along the x-axis
double xMax() const { return _xRange.second; }
/// Return the lowest-valued bin edge along the y-axis
double yMin() const { return _yRange.first; }
/// Return the highest-valued bin edge along the y-axis
double yMax() const { return _yRange.second; }
/// Add a bin, providing its x- and y- edge ranges
void addBin(EdgePair1D xrange, EdgePair1D yrange) {
_checkUnlocked();
Bins newBins = _bins;
newBins.push_back(Bin(xrange, yrange));
_updateAxis(newBins);
}
/// Add a pre-made bin
void addBin(const Bin& bin) {
_checkUnlocked();
Bins newBins = _bins;
newBins.push_back(bin);
_updateAxis(newBins);
}
/// Add a vector of pre-made bins
void addBins(const Bins& bins) {
if (bins.size() == 0) return;
_checkUnlocked();
Bins newBins = _bins;
/// @todo Reinstate when C++11 allowed in API
// for (const Bin& b : bins)
// newBins.push_back(b);
for (size_t ib = 0; ib < bins.size(); ++ib) newBins.push_back(bins[ib]);
_updateAxis(newBins);
}
/// Add a contiguous set of bins to an axis, via their list of edges
void addBins(const std::vector<double>& xedges, const std::vector<double>& yedges) {
if (xedges.size() == 0) return;
if (yedges.size() == 0) return;
_checkUnlocked();
Bins newBins = _bins;
for (size_t xi = 0; xi < xedges.size()-1; xi++) {
for (size_t yi = 0; yi < yedges.size()-1; yi++) {
const std::pair<double,double> xx = std::make_pair(xedges[xi], xedges[xi+1]);
const std::pair<double,double> yy = std::make_pair(yedges[yi], yedges[yi+1]);
// std::cout << "New bin with edges: [(" << xx.first << "," << xx.second << "), " << yy.first << "," << yy.second << ")]" << std::endl;
newBins.push_back(Bin(xx, yy));
}
}
_updateAxis(newBins);
}
/// Access bin by index
Bin& bin(size_t i) {
return _bins[i];
}
/// Access bin by index (const)
const Bin& bin(size_t i) const {
return _bins[i];
}
/// Get the bin index of the bin containing point (x, y).
int binIndexAt(double x, double y) const {
size_t xi = _binSearcherX.index(x) - 1;
size_t yi = _binSearcherY.index(y) - 1;
if (xi > _nx) return -1;
if (yi > _ny) return -1;
return _indexes[_index(_nx, xi, yi)];
}
/// Get the bin containing point (x, y).
Bin& binAt(double x, double y) {
const int ret = binIndexAt(x, y);
if (ret == -1) throw RangeError("No bin found!!");
return bin(ret);
}
/// Get the bin containing point (x, y) (const).
const Bin& binAt(double x, double y) const {
const int ret = binIndexAt(x, y);
if (ret == -1) throw RangeError("No bin found!!");
return bin(ret);
}
/// Return the total distribution (non-const)
DBN& totalDbn() {
return _dbn;
}
/// Return the total distribution (const)
const DBN& totalDbn() const {
return _dbn;
}
/// Set the total distribution: CAREFUL!
void setTotalDbn(const DBN& dbn) {
_dbn = dbn;
}
/// Return the bins vector (non-const)
Bins& bins() {
return _bins;
}
/// Return the bins vector (const)
const Bins& bins() const {
return _bins;
}
/// Equality operator (on binning only)
/// @todo Change as discussed below if we expose the Axis classes for direct use
// (DM: Doesn't this break the semantics of equality? As it's used only
// rarely, isn't there a real case for having a "binningsCompatible" or
// similar method?)
bool operator == (const Axis2D& other) const {
if (numBins() != other.numBins()) return false;
for (size_t i = 0; i < numBins(); i++)
if (!(fuzzyEquals(bin(i).xMin(), other.bin(i).xMin()) &&
fuzzyEquals(bin(i).xMax(), other.bin(i).xMax()) &&
fuzzyEquals(bin(i).yMin(), other.bin(i).yMin()) &&
fuzzyEquals(bin(i).yMax(), other.bin(i).yMax())))
return false;
return true;
}
/// Non-equality operator
bool operator != (const Axis2D& other) const {
return ! operator == (other);
}
/// Addition operator
Axis2D<BIN2D, DBN>& operator += (const Axis2D<BIN2D, DBN>& toAdd) {
if (*this != toAdd) {
throw LogicError("YODA::Axis2D: Cannot add axes with different binnings.");
}
for (size_t i = 0; i < bins().size(); ++i) {
bin(i) += toAdd.bin(i);
}
_dbn += toAdd._dbn;
return *this;
}
/// Subtraction operator
Axis2D<BIN2D, DBN>& operator -= (const Axis2D<BIN2D, DBN>& toSubtract) {
if (*this != toSubtract) {
throw LogicError("YODA::Axis2D: Cannot add axes with different binnings.");
}
for (size_t i = 0; i < bins().size(); ++i) {
bin(i) -= toSubtract.bin(i);
}
_dbn -= toSubtract._dbn;
return *this;
}
private:
void _checkUnlocked(void) {
// Ensure that axis is not locked
if (_locked)
- throw LockError("Attempting to update a locked axis");
+ throw LockError("Attempting to update a locked 2D axis");
}
/// Detect if there is a binning gap in the given bin index range
/// @todo WRITE THIS!
bool _gapInRange(size_t from, size_t to) {
Bin& toBin = bin(to);
Bin& fromBin = bin(from);
return true;
}
void _updateAxis(Bins& bins) {
// Deal with the case that there are no bins supplied (who called that?!)
if (bins.size() == 0) {
_binSearcherX = Utils::BinSearcher();
_binSearcherY = Utils::BinSearcher();
_nx = 0;
_ny = 0;
_xRange = std::make_pair(0, 0);
_yRange = std::make_pair(0, 0);
}
// Sort the bins
std::sort(bins.begin(), bins.end());
// Create the edges
std::vector<double> xedges, yedges, xwidths, ywidths;
for (const Bin& bin : bins) {
xedges.push_back(bin.xMin());
xedges.push_back(bin.xMax());
xwidths.push_back(bin.xWidth());
yedges.push_back(bin.yMin());
yedges.push_back(bin.yMax());
ywidths.push_back(bin.yWidth());
}
// Sort the edges and widths
std::sort(xedges.begin(), xedges.end());
std::sort(yedges.begin(), yedges.end());
std::sort(xwidths.begin(), xwidths.end());
std::sort(ywidths.begin(), ywidths.end());
// Obtain the median widths as a typical scale for uniqueness comparisons
const double medianxwidth = xwidths[ (xwidths.size()-1)/2 ];
const double medianywidth = ywidths[ (ywidths.size()-1)/2 ];
// Uniqueify the bin edges in the x- and y-cut vectors, with some numerical fuzziness
xedges.resize(std::unique(xedges.begin(), xedges.end(), CmpFloats(1e-3, medianxwidth)) - xedges.begin());
yedges.resize(std::unique(yedges.begin(), yedges.end(), CmpFloats(1e-3, medianywidth)) - yedges.begin());
const size_t nx = xedges.size();
const size_t ny = yedges.size();
const size_t N = nx * ny;
//std::cout << "Unique Axis2D edge list sizes: nx = " << nx << ", ny = " << ny << std::endl;
assert(bins.size() <= (nx-1)*(ny-1) && "Input bins vector size must agree with computed number of unique bins");
// Create a sea of indices, starting with an all-gaps configuration
std::vector<ssize_t> indexes(N, -1);
// Iterate through bins and find out which
Utils::BinSearcher xSearcher(xedges);
Utils::BinSearcher ySearcher(yedges);
for (size_t i = 0; i < bins.size(); ++i) {
Bin& bin = bins[i];
// std::cout << "Bin #" << i << " edges: "
// << "[(" << bin.xMin() << "," << bin.xMax() << "), "
// << "(" << bin.yMin() << "," << bin.yMax() << ")] " << std::endl;
const size_t xiMin= xSearcher.index(bin.xMin()) - 1;
const size_t xiMax= xSearcher.index(bin.xMax()) - 1;
const size_t yiMin = ySearcher.index(bin.yMin()) - 1;
const size_t yiMax = ySearcher.index(bin.yMax()) - 1;
// std::cout << "Sub-bin range indices: x = " << xiMin << ".." << xiMax << ", y = " << yiMin << ".." << yiMax << std::endl;
// Loop over sub-bins in the edge list and assign indices / detect overlaps
for (size_t xi = xiMin; xi < xiMax; xi++) {
for (size_t yi = yiMin; yi < yiMax; yi++) {
const size_t ii = _index(nx, xi, yi);
if (indexes[ii] != -1) {
std::stringstream ss;
ss << "Bin edges overlap! Bin #" << i << " with edges "
<< "[(" << bin.xMin() << "," << bin.xMax() << "), "
<< "(" << bin.yMin() << "," << bin.yMax() << ")] "
<< "overlaps bin #" << indexes[ii] << " in sub-bin #" << ii;
throw RangeError(ss.str());
}
indexes[ii] = i;
}
}
}
// Job's a good'n - let's change our class.
_nx = nx;
_ny = ny;
_xRange = std::make_pair(xedges.front(), xedges.back());
_yRange = std::make_pair(yedges.front(), yedges.back());
_indexes = indexes;
_bins = bins;
_binSearcherX = xSearcher;
_binSearcherY = ySearcher;
}
/// Definition of global bin ID in terms of x and y bin IDs
static size_t _index(size_t nx, size_t x, size_t y) {
return y * nx + x;
}
/// @brief Get the outflow array index by x-index and y-index
///
/// Indices are -1 = below range, 0 = in range, +1 = above range, e.g. (+1,
/// -1) is in the "bottom right" position by being greater than the greatest
/// x-edge and less than the lowest y-edge.
static size_t _outflowIndex(int ix, int iy) {
if (ix == 0 || iy == 0)
throw UserError("The in-range (0,0) index pair is not a valid outflow specifier");
ix += 1;
iy += 1;
if (ix > 2 || iy > 2)
throw UserError("Outflow index out of range: valid indices are -1, 0, 1");
size_t rtn = 3*ix + iy; // uncorrected for (0,0) index offset
if (rtn > 4) rtn -= 1; // offset correction (note that raw rtn == 4 is not possible)
return rtn;
}
/// @name Data structures
//@{
/// Bins vector
Bins _bins;
/// Total distribution
DBN _dbn;
// Outflows
Outflows _outflows;
// Binsearcher, for searching bins
Utils::BinSearcher _binSearcherX;
Utils::BinSearcher _binSearcherY;
EdgePair1D _xRange;
EdgePair1D _yRange;
// Mapping from bin-searcher indices to bin indices (allowing gaps)
std::vector<ssize_t> _indexes;
// Necessary for bounds checking and indexing
size_t _nx;
size_t _ny;
/// Whether modifying bin edges is permitted
bool _locked;
//@}
};
}
#endif
diff --git a/src/Histo2D.cc b/src/Histo2D.cc
--- a/src/Histo2D.cc
+++ b/src/Histo2D.cc
@@ -1,406 +1,406 @@
// -*- C++ -*-
//
// This file is part of YODA -- Yet more Objects for Data Analysis
// Copyright (C) 2008-2017 The YODA collaboration (see AUTHORS for details)
//
#include "YODA/Histo2D.h"
#include "YODA/Profile2D.h"
#include "YODA/Scatter3D.h"
#include "YODA/Utils/StringUtils.h"
using namespace std;
namespace YODA {
+ /// Copy constructor with optional new path
+ Histo2D::Histo2D(const Histo2D& h, const std::string& path)
+ : AnalysisObject("Histo2D", (path.size() == 0) ? h.path() : path, h, h.title()),
+ _axis(h._axis)
+ { }
+
+
+ /// Constructor from a Scatter3D's binning, with optional new path
+ Histo2D::Histo2D(const Scatter3D& s, const std::string& path)
+ : AnalysisObject("Histo2D", (path.size() == 0) ? s.path() : path, s, s.title())
+ {
+ std::vector<HistoBin2D> bins;
+ for (const Scatter3D::Point& p : s.points()) {
+ bins.push_back(HistoBin2D(p.xMin(), p.xMax(), p.yMin(), p.yMax()));
+ }
+ _axis = Histo2DAxis(bins);
+ }
+
+
+ /// Constructor from a Profile2D's binning, with optional new path
+ Histo2D::Histo2D(const Profile2D& p, const std::string& path)
+ : AnalysisObject("Histo2D", (path.size() == 0) ? p.path() : path, p, p.title())
+ {
+ std::vector<HistoBin2D> bins;
+ for (const ProfileBin2D& b : p.bins()) {
+ bins.push_back(HistoBin2D(b.xMin(), b.xMax(), b.yMin(), b.yMax()));
+ }
+ _axis = Histo2DAxis(bins);
+ }
+
+
+ ////////////////////////////////////
+
+
void Histo2D::fill(double x, double y, double weight, double fraction) {
if ( std::isnan(x) ) throw RangeError("X is NaN");
if ( std::isnan(y) ) throw RangeError("Y is NaN");
// Fill the overall distribution
_axis.totalDbn().fill(x, y, weight, fraction);
// Fill the bins and overflows
/// Unify this with Profile2D's version, when binning and inheritance are reworked
if (inRange(x, _axis.xMin(), _axis.xMax()) && inRange(y, _axis.yMin(), _axis.yMax())) {
try {
/// @todo Replace try block with a check that there is a bin at x, y
binAt(x, y).fill(x, y, weight, fraction);
} catch (const RangeError& re) { }
}
/// @todo Reinstate! With outflow axis bin lookup
// else {
// size_t ix(0), iy(0);
// if (x < _axis.xMin()) ix = -1; else if (x >= _axis.xMax()) ix = 1;
// if (y < _axis.yMin()) iy = -1; else if (y >= _axis.yMax()) iy = 1;
// _axis.outflow(ix, iy).fill(x, y, weight, fraction);
// }
// Lock the axis now that a fill has happened
_axis._setLock(true);
}
void Histo2D::fillBin(size_t i, double weight, double fraction) {
pair<double, double> mid = bin(i).xyMid();
fill(mid.first, mid.second, weight, fraction);
}
/////////////// COMMON TO ALL BINNED
double Histo2D::numEntries(bool includeoverflows) const {
if (includeoverflows) return totalDbn().numEntries();
unsigned long n = 0;
for (const Bin& b : bins()) n += b.numEntries();
return n;
}
double Histo2D::effNumEntries(bool includeoverflows) const {
if (includeoverflows) return totalDbn().effNumEntries();
double n = 0;
for (const Bin& b : bins()) n += b.effNumEntries();
return n;
}
double Histo2D::sumW(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().sumW();
double sumw = 0;
for (const Bin& b : bins()) sumw += b.sumW();
return sumw;
}
double Histo2D::sumW2(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().sumW2();
double sumw2 = 0;
for (const Bin& b : bins()) sumw2 += b.sumW2();
return sumw2;
}
////////////////
double Histo2D::xMean(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().xMean();
Dbn2D dbn;
for (const HistoBin2D& b : bins()) dbn += b.dbn();
return dbn.xMean();
}
double Histo2D::yMean(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().yMean();
Dbn2D dbn;
for (const HistoBin2D& b : bins()) dbn += b.dbn();
return dbn.yMean();
}
double Histo2D::xVariance(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().xVariance();
Dbn2D dbn;
for (const HistoBin2D& b : bins()) dbn += b.dbn();
return dbn.xVariance();
}
double Histo2D::yVariance(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().yVariance();
Dbn2D dbn;
for (const HistoBin2D& b : bins()) dbn += b.dbn();
return dbn.yVariance();
}
double Histo2D::xStdErr(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().xStdErr();
Dbn2D dbn;
for (const HistoBin2D& b : bins()) dbn += b.dbn();
return dbn.xStdErr();
}
double Histo2D::yStdErr(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().yStdErr();
Dbn2D dbn;
for (const HistoBin2D& b : bins()) dbn += b.dbn();
return dbn.yStdErr();
}
double Histo2D::xRMS(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().xRMS();
Dbn2D dbn;
for (const HistoBin2D& b : bins()) dbn += b.dbn();
return dbn.xRMS();
}
double Histo2D::yRMS(bool includeoverflows) const {
if (includeoverflows) return _axis.totalDbn().yRMS();
Dbn2D dbn;
for (const HistoBin2D& b : bins()) dbn += b.dbn();
return dbn.yRMS();
}
/////////////////////////////////////
- /// Copy constructor with optional new path
- Histo2D::Histo2D(const Histo2D& h, const std::string& path)
- : AnalysisObject("Histo2D", (path.size() == 0) ? h.path() : path, h, h.title()),
- _axis(h._axis)
- { }
-
-
- /// Constructor from a Scatter3D's binning, with optional new path
- Histo2D::Histo2D(const Scatter3D& s, const std::string& path)
- : AnalysisObject("Histo2D", (path.size() == 0) ? s.path() : path, s, s.title())
- {
- std::vector<HistoBin2D> bins;
- for (const Scatter3D::Point& p : s.points()) {
- bins.push_back(HistoBin2D(p.xMin(), p.xMax(), p.yMin(), p.yMax()));
- }
- _axis = Histo2DAxis(bins);
- }
-
-
- /// Constructor from a Profile2D's binning, with optional new path
- Histo2D::Histo2D(const Profile2D& p, const std::string& path)
- : AnalysisObject("Histo2D", (path.size() == 0) ? p.path() : path, p, p.title())
- {
- std::vector<HistoBin2D> bins;
- for (const ProfileBin2D& b : p.bins()) {
- bins.push_back(HistoBin2D(b.xMin(), b.xMax(), b.yMin(), b.yMax()));
- }
- _axis = Histo2DAxis(bins);
- }
-
-
- ////////////////////////////////////
-
-
// Histo1D Histo2D::cutterX(double atY, const std::string& path, const std::string& title) {
// if (!_axis.isGrid()) throw GridError("Attempt to cut a Histo2D that is not a grid!");
// if (atY < yMin() || atY > highEdgeY()) throw RangeError("Y is outside the grid");
// vector<HistoBin1D> tempBins;
// for (double i = binByCoord(xMin(), atY).xMin(); i < highEdgeX(); i += binByCoord(i, atY).widthX()) {
// const HistoBin2D& b2 = binByCoord(i, atY);
// const Dbn1D dbn2(b2.numEntries(), b2.sumW(), b2.sumW2(), b2.sumWX(), b2.sumWX2());
// tempBins.push_back(HistoBin1D(b2.xMin(), b2.highEdgeX(), dbn2));
// }
// /// Setting under/over flows
// Dbn2D underflow;
// underflow += _axis.outflows()[7][_axis.getBinRow(_axis.getBinIndex(xMin(), atY))];
// Dbn2D overflow;
// overflow += _axis.outflows()[3][_axis.getBinRow(_axis.getBinIndex(xMin(), atY))];
// return Histo1D(tempBins, _axis.totalDbn().transformX(), underflow.transformX(), overflow.transformX(), path, title);
// }
// Histo1D Histo2D::cutterY(double atX, const std::string& path, const std::string& title) {
// if (!_axis.isGrid()) throw GridError("Attempt to cut a Histo2D that is not a grid!");
// if (atX < xMin() || atX > highEdgeX()) throw RangeError("X is outside the grid");
// vector<HistoBin1D> tempBins;
// for (double i = binByCoord(atX, yMin()).yMin(); i < highEdgeY(); i += binByCoord(atX, i).widthY()) {
// const HistoBin2D& b2 = binByCoord(atX, i);
// const Dbn1D dbn2(b2.numEntries(), b2.sumW(), b2.sumW2(), b2.sumWX(), b2.sumWX2());
// tempBins.push_back(HistoBin1D(b2.yMin(), b2.highEdgeY(), dbn2));
// }
// // Setting under/over flows
// Dbn2D underflow;
// underflow += _axis.outflows()[1][_axis.getBinColumn(_axis.getBinIndex(atX, yMin()))];
// Dbn2D overflow;
// overflow += _axis.outflows()[5][_axis.getBinColumn(_axis.getBinIndex(atX, yMin()))];
// Dbn2D total = _axis.totalDbn();
// // Making sure that we rotate our distributions, as we are cutting parallel to Y axis now
// total.flipXY();
// underflow.flipXY();
// overflow.flipXY();
// return Histo1D(tempBins, total.transformX(), underflow.transformX(), overflow.transformX(), path, title);
// }
// Profile1D Histo2D::mkProfileX() {
// if (!_axis.isGrid()) throw GridError("Profile1D cannot be made from a histogram that is not a grid!");
// vector<ProfileBin1D> prof;
// for(int i = xMin() + _axis.bin(0).xMid(); i < highEdgeX(); i+= _axis.bin(0).widthX()) {
// HistoBin2D& bin(_axis.binByCoord(i, yMin()));
// HistoBin2D composite(bin.xMin(), bin.xMax(), bin.yMin(), bin.yMax()) ;
// for(int j = yMin() + _axis.bin(0).yMid(); j < highEdgeY(); j += _axis.bin(0).widthY()) {
// composite += _axis.binByCoord(i, j);
// }
// prof.push_back(composite.transformX());
// }
// vector<vector<Dbn2D> >& outflows = _axis.outflows();
// /// Properly setting an underflow
// Dbn2D underflow;
// underflow += outflows[0][0]; underflow += outflows[6][0];
// for(size_t i = 0; i < outflows[7].size(); ++i) {
// underflow += outflows[7][i];
// }
// /// Setting an overflow
// Dbn2D overflow;
// overflow += outflows[2][0]; overflow += outflows[4][0];
// for(size_t i = 0; i < outflows[3].size(); ++i) {
// overflow += outflows[3][i];
// }
// /// And constructing a profile 1D from all this data
// Profile1D ret(prof, _axis.totalDbn(), underflow, overflow);
// return ret;
// }
// Profile1D Histo2D::mkProfileY() {
// if (!_axis.isGrid()) throw GridError("Profile1D cannot be made from a histogram that is not a grid!");
// vector<ProfileBin1D> prof;
// for(int i = yMin() + _axis.bin(0).yMid(); i < highEdgeY(); i+= _axis.bin(0).widthY()) {
// HistoBin2D& bin(_axis.binByCoord(i, yMin()));
// HistoBin2D composite(bin.xMin(), bin.xMax(), bin.yMin(), bin.yMax()) ;
// for(int j = xMin() + _axis.bin(0).xMid(); j < highEdgeX(); j += _axis.bin(0).widthX()) {
// composite += _axis.binByCoord(i, j);
// }
// prof.push_back(composite.transformY());
// }
// vector<vector<Dbn2D> >& outflows = _axis.outflows();
// /// Properly setting an underflow
// Dbn2D underflow;
// underflow += outflows[0][0]; underflow += outflows[2][0];
// for(size_t i = 0; i < outflows[1].size(); ++i) {
// underflow += outflows[1][i];
// }
// /// Setting an overflow
// Dbn2D overflow;
// overflow += outflows[6][0]; overflow += outflows[4][0];
// for(size_t i = 0; i < outflows[5].size(); ++i) {
// overflow += outflows[5][i];
// }
// /// Setting a flipped total distribution
// Dbn2D td = _axis.totalDbn();
// td.flipXY();
// /// And constructing a profile 1D from all this data
// Profile1D ret(prof, td, underflow, overflow);
// return ret;
// }
Scatter3D divide(const Histo2D& numer, const Histo2D& denom) {
Scatter3D rtn;
for (size_t i = 0; i < numer.numBins(); ++i) {
const HistoBin2D& b1 = numer.bin(i);
const HistoBin2D& b2 = denom.bin(i);
/// @todo Create a compatibleBinning function? Or just compare vectors of edges().
if (!fuzzyEquals(b1.xMin(), b2.xMin()) || !fuzzyEquals(b1.xMax(), b2.xMax()))
throw BinningError("x binnings are not equivalent in " + numer.path() + " / " + denom.path());
if (!fuzzyEquals(b1.yMin(), b2.yMin()) || !fuzzyEquals(b1.yMax(), b2.yMax()))
throw BinningError("y binnings are not equivalent in " + numer.path() + " / " + denom.path());
// Assemble the x value and error
// Use the midpoint of the "bin" for the new central x value, in the absence of better information
const double x = b1.xMid();
const double exminus = x - b1.xMin();
const double explus = b1.xMax() - x;
// Assemble the y value and error
// Use the midpoint of the "bin" for the new central y value, in the absence of better information
const double y = b1.yMid();
const double eyminus = y - b1.yMin();
const double eyplus = b1.yMax() - y;
// Assemble the z value and error
double z = std::numeric_limits<double>::quiet_NaN();
double ez = std::numeric_limits<double>::quiet_NaN();
if (b2.height() == 0 || (b1.height() == 0 && b1.heightErr() != 0)) { ///< @todo Ok?
// z = std::numeric_limits<double>::quiet_NaN();
// ez = std::numeric_limits<double>::quiet_NaN();
// throw LowStatsError("Requested division of empty bin");
} else {
z = b1.height() / b2.height();
/// @todo Is this the exact error treatment for all (uncorrelated) cases? Behaviour around 0? +1 and -1 fills?
const double relerr_1 = b1.heightErr() != 0 ? b1.relErr() : 0;
const double relerr_2 = b2.heightErr() != 0 ? b2.relErr() : 0;
ez = z * sqrt(sqr(relerr_1) + sqr(relerr_2));
}
/// Deal with +/- errors separately, inverted for the denominator contributions:
/// @todo check correctness with different signed numerator and denominator.
//const double eyplus = y * sqrt( sqr(p1.yErrPlus()/p1.y()) + sqr(p2.yErrMinus()/p2.y()) );
//const double eyminus = y * sqrt( sqr(p1.yErrMinus()/p1.y()) + sqr(p2.yErrPlus()/p2.y()) );
rtn.addPoint(x, y, z, exminus, explus, eyminus, eyplus, ez, ez);
}
assert(rtn.numPoints() == numer.numBins());
return rtn;
}
Scatter3D efficiency(const Histo2D& accepted, const Histo2D& total) {
Scatter3D tmp = divide(accepted, total);
for (size_t i = 0; i < accepted.numBins(); ++i) {
const HistoBin2D& b_acc = accepted.bin(i);
const HistoBin2D& b_tot = total.bin(i);
Point3D& point = tmp.point(i);
/// BEGIN DIMENSIONALITY-INDEPENDENT BIT TO SHARE WITH H1
// Check that the numerator is consistent with being a subset of the denominator
/// @note Neither effNumEntries nor sumW are guaranteed to satisfy num <= den for general weights!
if (b_acc.numEntries() > b_tot.numEntries())
throw UserError("Attempt to calculate an efficiency when the numerator is not a subset of the denominator: "
+ Utils::toStr(b_acc.numEntries()) + " entries / " + Utils::toStr(b_tot.numEntries()) + " entries");
// If no entries on the denominator, set eff = err = 0 and move to the next bin
double eff = std::numeric_limits<double>::quiet_NaN();
double err = std::numeric_limits<double>::quiet_NaN();
try {
if (b_tot.sumW() != 0) {
eff = b_acc.sumW() / b_tot.sumW(); //< Actually this is already calculated by the division...
err = sqrt(abs( ((1-2*eff)*b_acc.sumW2() + sqr(eff)*b_tot.sumW2()) / sqr(b_tot.sumW()) ));
}
} catch (const LowStatsError& e) {
//
}
/// END DIMENSIONALITY-INDEPENDENT BIT TO SHARE WITH H1
point.setZ(eff, err);
}
return tmp;
}
/// @todo Add asymm for 2D histos?
}

File Metadata

Mime Type
text/x-diff
Expires
Tue, Nov 19, 3:35 PM (1 d, 19 h)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
3804974
Default Alt Text
(115 KB)

Event Timeline