Page MenuHomeHEPForge
Feed Advanced Search

May 4 2021

tlatham committed rEVTGENec08fcebd85b: Fix bug in CMake configuration of installation locations (authored by tlatham).
Fix bug in CMake configuration of installation locations
May 4 2021, 4:18 PM
tlatham committed rEVTGEN32010ad19e99: Allow suppression of warnings from external dependencies (authored by tlatham).
Allow suppression of warnings from external dependencies
May 4 2021, 4:05 PM
tlatham updated the test plan for D58: Rename member variables to follow convention of m_ prefix.
May 4 2021, 11:46 AM · Restricted Project

Apr 26 2021

tlatham closed D69: Fix doxygen problems.
Apr 26 2021, 5:45 PM · Laura
tlatham committed rLAURA8e843afe46d7: Fix doxygen problems (authored by tlatham).
Fix doxygen problems
Apr 26 2021, 5:45 PM

Apr 21 2021

tlatham published D69: Fix doxygen problems for review.

This is mainly a fix of Doxygen warnings but I have taken the opportunity to streamline very slightly the arguments to LauKMatrixPropagator::calcGamma, hence the request for review.

Apr 21 2021, 10:34 AM · Laura
tlatham committed rLAURAe0cce8950506: Draft GitLab CI for master branch (authored by tlatham).
Draft GitLab CI for master branch
Apr 21 2021, 10:27 AM
tlatham committed rLAURAa177334bce6e: Small tidy-ups in LauDecayTimePdf (authored by tlatham).
Small tidy-ups in LauDecayTimePdf
Apr 21 2021, 9:24 AM
tlatham committed rLAURA853e7a387fbf: Sort out caching for per-event decay time error (authored by tlatham).
Sort out caching for per-event decay time error
Apr 21 2021, 9:23 AM
tlatham committed rLAURAf582b092ff30: Ensure all knots are passed to Minuit (whether fixed or floated) if any are… (authored by tlatham).
Ensure all knots are passed to Minuit (whether fixed or floated) if any are…
Apr 21 2021, 9:23 AM
tlatham committed rLAURAcce3cae53a69: Fix typo spotted by Mark (authored by tlatham).
Fix typo spotted by Mark
Apr 21 2021, 9:23 AM
tlatham committed rLAURA72c4b374b53a: Large refactoring to avoid lots of duplication (authored by tlatham).
Large refactoring to avoid lots of duplication
Apr 21 2021, 9:23 AM
tlatham committed rLAURA898147ca4681: Get rid of a couple more unnecessary divisions (authored by tlatham).
Get rid of a couple more unnecessary divisions
Apr 21 2021, 9:23 AM
tlatham committed rLAURA66281ca68aa7: Improve the caching - working except for per-event DTR (authored by tlatham).
Improve the caching - working except for per-event DTR
Apr 21 2021, 9:23 AM

Apr 20 2021

tlatham closed T144: EvtGen does not build with Pythia 8.304 as Resolved.
Apr 20 2021, 2:37 PM · Restricted Project
tlatham committed rEVTGENf676c2338a31: Fix compilation with Pythia 8.304 (authored by tlatham).
Fix compilation with Pythia 8.304
Apr 20 2021, 2:36 PM
tlatham added a revision to T144: EvtGen does not build with Pythia 8.304: Unknown Object (Differential Revision).
Apr 20 2021, 2:23 PM · Restricted Project
tlatham triaged T144: EvtGen does not build with Pythia 8.304 as Normal priority.
Apr 20 2021, 2:07 PM · Restricted Project

Apr 16 2021

tlatham committed rLAURA18bc17ba56b6: Fix some warnings from clang10 build (authored by tlatham).
Fix some warnings from clang10 build
Apr 16 2021, 3:14 PM
tlatham committed rLAURA5e5fd78f4946: Fix generation bug for CP-eigenstate case (authored by tlatham).
Fix generation bug for CP-eigenstate case
Apr 16 2021, 3:14 PM

Mar 30 2021

tlatham committed rLAURA6c4fe49ba0d9: Merge branch 'master' into timedep-branch (authored by tlatham).
Merge branch 'master' into timedep-branch
Mar 30 2021, 5:06 PM

Mar 26 2021

tlatham committed rLAURA4684b784bdbd: Fix toggling linear interpolation in Lau1DHistPdf (authored by tlatham).
Fix toggling linear interpolation in Lau1DHistPdf
Mar 26 2021, 3:47 PM
tlatham closed T142: Linear interpolation always enabled for 1D histogram PDFs as Resolved by committing rLAURA4684b784bdbd: Fix toggling linear interpolation in Lau1DHistPdf.
Mar 26 2021, 3:47 PM · Laura
tlatham triaged T142: Linear interpolation always enabled for 1D histogram PDFs as Normal priority.
Mar 26 2021, 3:42 PM · Laura
tlatham claimed T142: Linear interpolation always enabled for 1D histogram PDFs.
Mar 26 2021, 3:39 PM · Laura

Mar 18 2021

tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.
In D58#1640, @kreps wrote:

I think I have it now all, but I ran to another issue with arcanist, which refused to upload diff on a large file without marking it binary. The file is src/EvtGenModels/EvtVubAC.cpp and we might need to change it back from binary when we finish this.

Mar 18 2021, 10:12 AM · Restricted Project
tlatham updated subscribers of T141: Review all models to check which could be unified.
Mar 18 2021, 9:27 AM · Restricted Project

Mar 17 2021

tlatham retitled D58: Rename member variables to follow convention of m_ prefix from Started to remove _ to Started to rename member variables to avoid leading underscores.
Mar 17 2021, 11:27 AM · Restricted Project
tlatham updated subscribers of D58: Rename member variables to follow convention of m_ prefix.

@kreps , @jback feel free to add yourselves as reviewers too
We should also decide whether to extend this to the rest of the package now or leave to later. I'd probably favour doing it all in one go.

Mar 17 2021, 11:24 AM · Restricted Project
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.

Rebase on master

Mar 17 2021, 11:20 AM · Restricted Project
tlatham committed rEVTGENccad6c7a5a98: Fix some errors and warnings when compiling on macOS (authored by tlatham).
Fix some errors and warnings when compiling on macOS
Mar 17 2021, 10:19 AM
tlatham closed D63: Fix some errors and warnings when compiling on macOS.
Mar 17 2021, 10:19 AM · Restricted Project

Mar 16 2021

tlatham requested review of D63: Fix some errors and warnings when compiling on macOS.
Mar 16 2021, 11:26 PM · Restricted Project

Mar 12 2021

tlatham committed rLAURA5d4dc2d8467a: Sort out includes in flavour-tagging classes (authored by tlatham).
Sort out includes in flavour-tagging classes
Mar 12 2021, 12:00 AM

Mar 10 2021

tlatham added a comment to T98: Doxygenate the code.

rEVTGEN6d93ea5c4f5e takes care of the CMake configuration to automate the generation of the documentation.
Now just need to add the Doxygen comments to all the classes!

Mar 10 2021, 5:57 PM · Restricted Project
tlatham committed rEVTGEN6d93ea5c4f5e: Initial setup for Doxygen generation (authored by tlatham).
Initial setup for Doxygen generation
Mar 10 2021, 5:53 PM
tlatham closed D51: Initial setup for Doxygen generation.
Mar 10 2021, 5:53 PM · Restricted Project
tlatham added a comment to D51: Initial setup for Doxygen generation.

Thanks @kreps , yes the README needs some text in the introduction but agree we can maybe add that in a separate step.
I've just finished going through the History file and making it looks reasonable in Markdown format, see:
https://evtgen.hepforge.org/doc/doxygen/test/md_History.html
So I think this can indeed be landed now.

Mar 10 2021, 11:54 AM · Restricted Project
tlatham updated the diff for D51: Initial setup for Doxygen generation.
  • Start to convert various files to Markdown format
Mar 10 2021, 11:51 AM · Restricted Project
tlatham committed rLAURA3bd3925d6e30: Fix reference to workers, left over from T112 (authored by tlatham).
Fix reference to workers, left over from T112
Mar 10 2021, 10:32 AM

Mar 9 2021

tlatham added a comment to D55: Updates to chi2 code.

Thanks for this @johndan. I'm not (yet) very familiar with RDataFrame, so bear with me while I look at that part.
I'm thinking that we could use YAML for the config file for this, which should make it more obvious what the various fields are, make it easier to deal with missing fields, etc.
I've been looking into YAML a little bit already in the context of T48 and this is actually a nicer case in which to try it out for the first time, so I'll have a bit of a play with it.

Mar 9 2021, 11:36 PM · Laura
tlatham added a comment to D55: Updates to chi2 code.

Thanks for this @johndan. I'm not (yet) very familiar with RDataFrame, so bear with me while I look at that part.
I'm thinking that we could use YAML for the config file for this, which should make it more obvious what the various fields are, make it easier to deal with missing fields, etc.
I've been looking into YAML a little bit already in the context of T48 and this is actually a nicer case in which to try it out for the first time, so I'll have a bit of a play with it.

Mar 9 2021, 11:35 PM · Laura
tlatham added a comment to T48: Read currently hard-coded values from data files.

Looking into using YAML for the data format and the yaml-cpp package for parsing it.

Mar 9 2021, 10:47 PM · Laura
tlatham committed rLAURA03d7d2dc0e0a: Update particle properties to PDG 2020 (authored by Mark Peter Whitehead <mark.peter.whitehead@cern.ch>).
Update particle properties to PDG 2020
Mar 9 2021, 10:19 PM
tlatham closed D57: Update to PDG 2020.
Mar 9 2021, 10:19 PM · Laura
tlatham accepted D57: Update to PDG 2020.

Great, many thanks indeed!

Mar 9 2021, 10:08 PM · Laura
tlatham added a comment to D57: Update to PDG 2020.

Thanks @mwhitehe, the numbers look good. Just one small inline comment.

Mar 9 2021, 4:59 PM · Laura
tlatham changed the visibility for D57: Update to PDG 2020.
Mar 9 2021, 4:46 PM · Laura

Mar 5 2021

tlatham committed rLAURAa55eac2fcf78: Fix sign error in nonSmearedCoshSinhIntegral and avoid some unnecessary… (authored by tlatham).
Fix sign error in nonSmearedCoshSinhIntegral and avoid some unnecessary…
Mar 5 2021, 4:26 PM
tlatham committed rLAURA36da76e7a751: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model… (authored by johndan).
Alterations to allow Blatt-Weisskopf factor for parent to be created in a model…
Mar 5 2021, 11:09 AM
tlatham closed D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
Mar 5 2021, 11:09 AM · Laura
tlatham accepted D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.

Many thanks for taking care of all these extensions to the K-matrix @johndan !
Will land this now.

Mar 5 2021, 11:02 AM · Laura

Mar 3 2021

tlatham added inline comments to D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
Mar 3 2021, 1:49 PM · Laura

Mar 2 2021

tlatham added inline comments to D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
Mar 2 2021, 1:31 PM · Laura
tlatham updated the diff for D51: Initial setup for Doxygen generation.
  • Start to convert various files to Markdown format
Mar 2 2021, 12:03 AM · Restricted Project

Mar 1 2021

tlatham added inline comments to D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
Mar 1 2021, 10:41 PM · Laura

Feb 23 2021

tlatham added a comment to D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.

Hi @johndan, thanks for this. Few comments inline.

Feb 23 2021, 11:48 PM · Laura

Feb 18 2021

tlatham updated the diff for D51: Initial setup for Doxygen generation.
  • Fix stripping of paths
Feb 18 2021, 2:43 PM · Restricted Project
tlatham added a comment to D51: Initial setup for Doxygen generation.

I've copied what is currently generated from this to the following page so that you can look at it more easily:
https://evtgen.hepforge.org/doc/doxygen/test/

Feb 18 2021, 2:25 PM · Restricted Project

Feb 17 2021

tlatham added a revision to T98: Doxygenate the code: D51: Initial setup for Doxygen generation.
Feb 17 2021, 7:32 PM · Restricted Project
tlatham added a task to D51: Initial setup for Doxygen generation: T98: Doxygenate the code.
Feb 17 2021, 7:32 PM · Restricted Project
tlatham changed the visibility for D51: Initial setup for Doxygen generation.
Feb 17 2021, 7:32 PM · Restricted Project

Feb 15 2021

tlatham added a comment to T137: Update documentation of K-matrix in paper to cover recent extensions.

Sounds good to me, many thanks @johndan.

Feb 15 2021, 12:12 PM · Laura
tlatham moved T137: Update documentation of K-matrix in paper to cover recent extensions from Bug reports to Documentation on the Laura board.
Feb 15 2021, 10:11 AM · Laura
tlatham added a parent task for T137: Update documentation of K-matrix in paper to cover recent extensions: T59: Allow the s0_prod parameter of the K-matrix to float.
Feb 15 2021, 10:08 AM · Laura
tlatham added a subtask for T59: Allow the s0_prod parameter of the K-matrix to float: T137: Update documentation of K-matrix in paper to cover recent extensions.
Feb 15 2021, 10:08 AM · Laura
tlatham triaged T137: Update documentation of K-matrix in paper to cover recent extensions as Normal priority.
Feb 15 2021, 10:08 AM · Laura
tlatham moved T136: Create an example for non S-wave K-matrix from Bug reports to New features / enhancements on the Laura board.
Feb 15 2021, 9:57 AM · Laura
tlatham triaged T136: Create an example for non S-wave K-matrix as Normal priority.
Feb 15 2021, 9:56 AM · Laura

Feb 11 2021

tlatham closed T135: Extend K-matrix to non S-wave cases as Resolved.
Feb 11 2021, 11:26 PM · Laura
tlatham committed rLAURA1bccda680e01: Implementation of higher-spin K-matrix (authored by johndan).
Implementation of higher-spin K-matrix
Feb 11 2021, 11:26 PM
tlatham closed D41: Implementation of higher-spin K-matrix.
Feb 11 2021, 11:26 PM · Laura
tlatham added a revision to T135: Extend K-matrix to non S-wave cases: D41: Implementation of higher-spin K-matrix.
Feb 11 2021, 11:21 PM · Laura
tlatham added a task to D41: Implementation of higher-spin K-matrix: T135: Extend K-matrix to non S-wave cases.
Feb 11 2021, 11:21 PM · Laura
tlatham triaged T135: Extend K-matrix to non S-wave cases as Normal priority.
Feb 11 2021, 11:21 PM · Laura

Feb 8 2021

tlatham accepted D41: Implementation of higher-spin K-matrix.

All looks good to me thanks @johndan. If @jback can do a final check over as well, since there have been a few changes, then hopefully we can get this landed soon.

Feb 8 2021, 11:31 AM · Laura

Feb 3 2021

tlatham moved T131: EvtGen tau decays using Pythia from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 3 2021, 1:41 PM · Restricted Project
tlatham requested changes to D41: Implementation of higher-spin K-matrix.

Thanks for all this @johndan it looks really nice. I've not really gone through the physics since I think you and @jback have gone through that thoroughly already. So these comments are all more technical.
There are various inline comments (mostly minor). Plus, here are a few general comments:

  • Do you have an example of using this generalisation of the K-matrix that could go into the examples dir?
  • Please remove the noexcept specifications on functions
    • I would prefer to do a systematic sweep through the package as part of T34 and I still need to fully firm up my understanding of when it is necessary/helpful to do this and what are the prerequisites for it to be valid to do so
    • Having said that, I'm pretty certain that some of those that you've specified noexcept are actually potentially throwing because they call functions that are themselves potentially throwing, e.g. TMatrixD::operator[]
  • Please update the release notes
Feb 3 2021, 12:07 AM · Laura

Feb 1 2021

tlatham closed T59: Allow the s0_prod parameter of the K-matrix to float as Resolved.
Feb 1 2021, 10:54 PM · Laura
tlatham committed rLAURAc9953f876dc8: Allow floating of parameters in the K-matrix (authored by johndan).
Allow floating of parameters in the K-matrix
Feb 1 2021, 10:53 PM
tlatham closed D39: Allow floating of parameters in the k-matrix.
Feb 1 2021, 10:53 PM · Laura
tlatham added a task to D39: Allow floating of parameters in the k-matrix: T59: Allow the s0_prod parameter of the K-matrix to float.
Feb 1 2021, 10:44 PM · Laura
tlatham added a revision to T59: Allow the s0_prod parameter of the K-matrix to float: D39: Allow floating of parameters in the k-matrix.
Feb 1 2021, 10:44 PM · Laura
tlatham accepted D39: Allow floating of parameters in the k-matrix.

Many thanks @johndan, this looks great. I understand from @jback that he's also happy with this, so I'll go ahead and land this one onto master.

Feb 1 2021, 10:34 PM · Laura

Jan 21 2021

tlatham committed rLAURAdc168ab57817: Fixes for generation and fitting of QFS decays (authored by tlatham).
Fixes for generation and fitting of QFS decays
Jan 21 2021, 10:14 PM

Jan 13 2021

tlatham committed rLAURAeb3470f669db: Remove call to LauDecayTimePdf::calcNorm within LauTimeDepFitModel… (authored by tlatham).
Remove call to LauDecayTimePdf::calcNorm within LauTimeDepFitModel…
Jan 13 2021, 10:56 PM
tlatham accepted D47: Model to generate 4-body phase-space decays in restricted part of the m12-m34 space..

Looks great, thanks Michal!

Jan 13 2021, 10:05 PM · Restricted Project

Jan 12 2021

tlatham added a comment to D47: Model to generate 4-body phase-space decays in restricted part of the m12-m34 space..

I'm afraid I don't have time right now to really fully review the physics. But hopefully your tests should have covered that. If we think it's necessary, perhaps we can ask the analysts who were requesting this to do some further validations?
I've added a follow-up on the issue of the various double* arguments - in short I'm also not a fan but let's leave them as they are for now.
I've also added one other small question on initialisation of member variables.
I don't see any other problems.

Jan 12 2021, 5:22 PM · Restricted Project

Jan 11 2021

tlatham committed rLAURA072a5ab2e5a7: Control floating of tau, deltaM, phiMix from command line (authored by tlatham).
Control floating of tau, deltaM, phiMix from command line
Jan 11 2021, 10:59 PM
tlatham committed rLAURA00f4654b1c0e: Modify Test_Dpipi to use standard set of histograms (authored by tlatham).
Modify Test_Dpipi to use standard set of histograms
Jan 11 2021, 10:40 PM

Jan 8 2021

tlatham changed the visibility for D47: Model to generate 4-body phase-space decays in restricted part of the m12-m34 space..
Jan 8 2021, 12:54 PM · Restricted Project

Jan 6 2021

tlatham added inline comments to D41: Implementation of higher-spin K-matrix.
Jan 6 2021, 4:55 PM · Laura
tlatham added a comment to D41: Implementation of higher-spin K-matrix.
In D41#1074, @johndan wrote:

General question, @tlatham : should I cherry-pick commits to bring this differential in line with the master (e.g. c38fa2a34f4a772754d1e8f610def10747d95104 - LauFormulaPar fix)?

Jan 6 2021, 4:43 PM · Laura
tlatham committed rEVTGEN5948de8d429c: Small cmake improvements for the RHEL8 (authored by Andrii Verbytskyi <averbyts@cern.ch>).
Small cmake improvements for the RHEL8
Jan 6 2021, 2:13 PM
tlatham closed D46: Small cmake improvements for the RHEL8.
Jan 6 2021, 2:12 PM · Restricted Project
tlatham accepted D46: Small cmake improvements for the RHEL8.

Thanks for these improvements. They look fine to me.

Jan 6 2021, 12:18 PM · Restricted Project
tlatham changed the visibility for D46: Small cmake improvements for the RHEL8.
Jan 6 2021, 12:17 PM · Restricted Project

Dec 16 2020

tlatham changed the visibility for T122: Use boost::program_options for executables.
Dec 16 2020, 2:35 PM · Laura

Dec 10 2020

tlatham closed T129: LauFormulaPar gives spurious error about dimension being 0 rather than 1 as Resolved.
Dec 10 2020, 5:34 PM · Laura
tlatham committed rLAURA89113f7a4cf8: Fix LauFormulaPar to follow change in behaviour of TFormula (authored by tlatham).
Fix LauFormulaPar to follow change in behaviour of TFormula
Dec 10 2020, 5:32 PM