Somehow I screwed up landing this and it hasn't automatically closed this revision. The changes are in master, however, so this can be closed manually.

Many thanks John, this looks good.

Tests look good. Once those three extra changes are done it can be merged.

Just 3 cases missed due to an #ifdef.
Otherwise I think it's looking good.
I'll try and run all the tests on it in the next few days to make completely certain, then this can be landed.

Many thanks, this looks good. The only thing is that the source files in src/EvtGenExternal haven't been modified. Can you build with -DEVTGEN_PYTHIA=ON -DEVTGEN_PHOTOS=ON -DEVTGEN_TAUOLA=ON?

Update documentation of arc land

Hi John,

Thanks for checking it through John.

• Fix to include external generator engines in Doxygen
• Few more manual renames
• Fix shadow and rename vars in EvtBBScalar
• Remove unused var from EvtXPsiGamma
• More renames
• Final lot of renames
• Fix indexing in Doxygen to ignore Evt and m_ prefixes
• Apply clang-format
• Fix some unwanted changes, tidy some names
• Remove unused class EvtDecayParm
• Reapply clang-format
• Few additional tidy ups
• Add pre-build checks to CI
• Fix formatting
• More formatting fixes after rebasing
• Few missed renames
• More formatting fixes

Possibly related to email thread "Potential weird EvtGen bug in semileptonic baryon decays(?)" from @florian et al.?

Thanks Michal, this indeed looks like a good set of clean-ups as well as the actual physics improvement.

Many thanks! Good to go as far as I'm concerned.

If you could also add to the History.md an entry for D80 that would be great, I completely forgot to do that before landing it just now!

Hi @jback, many thanks for checking this.
Certainly we should make sure that this is correct in the paper draft.
Once the paper is out we can take down the old guide and replace it with a copy of the paper or a link to the paper on arXiv.
But in the meantime, I think it is probably best also to correct the latex for the guide and perhaps put a new pdf on the webpage.

Thanks for these changes @kreps.
I have checked the consistency of the changes between B0 and B0bar and between the DEC and XML files and that all looks fine.
I also gave the two new scripts a quick try and they seem to work as advertised.
They are, however, missing the copyright section at the top. Ideally that section should also be updated to 2022 in the convertDecayFile.py script, then it can be copied into the two new files.
What does "Guide mark calculation" mean in ArgumentParser description in the two new scripts? Could these be made a bit more descriptive?

Rebased on master

Thanks Michal.
The config file is mostly just the default values with the only customisation coming in the first 5 lines:

• line 1 to run only the modernize-use-nullptr check
• line 3 to ensure that it warns about things in our header files
• line 5 so that it uses our .clang-format file for reformatting after any auto-applied changes

I have no doubt that the existing code will need cleaning up as we enable more checks. This is why I say "eventually" about having this run automatically, otherwise we'll just be swamped with warnings. A point for subsequent discussion will be what checks we want to use and in what order to start to gradually enable them and fix stuff as we go. I'll create a task where we can have such a discussion.

Thanks John!