- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 9 2021
Mar 5 2021
Many thanks for taking care of all these extensions to the K-matrix @johndan !
Will land this now.
Mar 3 2021
Mar 2 2021
- Start to convert various files to Markdown format
Mar 1 2021
Feb 23 2021
Hi @johndan, thanks for this. Few comments inline.
Feb 18 2021
- Fix stripping of paths
I've copied what is currently generated from this to the following page so that you can look at it more easily:
https://evtgen.hepforge.org/doc/doxygen/test/
Feb 17 2021
Feb 15 2021
Sounds good to me, many thanks @johndan.
Feb 11 2021
Feb 8 2021
Feb 3 2021
Thanks for all this @johndan it looks really nice. I've not really gone through the physics since I think you and @jback have gone through that thoroughly already. So these comments are all more technical.
There are various inline comments (mostly minor). Plus, here are a few general comments:
- Do you have an example of using this generalisation of the K-matrix that could go into the examples dir?
- Please remove the noexcept specifications on functions
- I would prefer to do a systematic sweep through the package as part of T34 and I still need to fully firm up my understanding of when it is necessary/helpful to do this and what are the prerequisites for it to be valid to do so
- Having said that, I'm pretty certain that some of those that you've specified noexcept are actually potentially throwing because they call functions that are themselves potentially throwing, e.g. TMatrixD::operator[]
- Please update the release notes
Feb 1 2021
Jan 21 2021
Jan 13 2021
Looks great, thanks Michal!
Jan 12 2021
I'm afraid I don't have time right now to really fully review the physics. But hopefully your tests should have covered that. If we think it's necessary, perhaps we can ask the analysts who were requesting this to do some further validations?
I've added a follow-up on the issue of the various double* arguments - in short I'm also not a fan but let's leave them as they are for now.
I've also added one other small question on initialisation of member variables.
I don't see any other problems.
Jan 11 2021
Jan 8 2021
Jan 6 2021
General question, @tlatham : should I cherry-pick commits to bring this differential in line with the master (e.g. c38fa2a34f4a772754d1e8f610def10747d95104 - LauFormulaPar fix)?
Thanks for these improvements. They look fine to me.
Dec 16 2020
Dec 10 2020
Thanks very much for this @johndan. It looks good.
I think it would just be good to take the opportunity while we're at it to allow any of the parameters to float.
We should also include the name of the propagator in the name of the parameters so that if we have more than one K-matrix in a given fit we don't get identically named parameters appearing - this will cause problems with the sim-fit for example.
See the inline comments for details.
Many thanks @kreps, looks good to me.
Dec 3 2020
- Update release notes
Dec 2 2020
OK, good to go now, I'll take care of landing it later on.
- Reference Maniphest task in release notes
Nov 27 2020
Nov 26 2020
Nov 23 2020
Hi Dan,
Nov 20 2020
Nov 18 2020
Oct 30 2020
Hi @jback, many thanks for the changes and apologies for the delay in responding to them.
I think this looks good to go now.
Unless @kreps has any comments I think you can go ahead and "land" it onto master.
Oct 15 2020
Oct 13 2020
Oct 8 2020
Oct 6 2020
Oct 2 2020
Hi @jback, sorry it's taken me so long to review this.
You can find here some technical points.
I'll try to compare the physics against the referenced paper next week, although I guess this was checked during the LHCb review?
You mention also testing it using testDecayModel but I can't find the json file(s) for this model. Could you include them in the next revision?